test(ui): poll compare-dock pointer hit after reveal transition

[BigSimmo]

Summary

Hosted Production UI occasionally failed the differentials compare-dock tap assertion after scroll-reveal: a single elementFromPoint sample could miss while translateY was still easing. Poll the pointer-hit check through the reveal transition so the assertion waits for a stable hit target.

The original phone Answer header gutter asymmetry is already fixed on main by #940 (--header-edge-pad); this PR does not change header spacing.

Verification

• npm run verify:pr-local
• npm run verify:ui when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed
• npm run verify:release before release or handoff confidence claims

UI verification: Chromium compare-dock test and prior full verify:ui on this branch lineage; hosted Production UI also passed after the poll harden on earlier heads.

• npm run eval:retrieval:quality (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed — not applicable
• npm run eval:rag -- --limit 15 + npm run eval:quality -- --rag-only when answer generation, the synthesis prompt, or answer post-processing changed — not applicable
• npm run check:production-readiness when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed — not applicable
• npm run check:deployment-readiness when deployment startup, hosting, or rollout behavior changed — not applicable

Risk and rollout

• Risk: Low. Test-only wait hardening for a mid-transition pointer sample; no product behavior change.
• Rollback: Revert the compare-dock expect.poll change in tests/ui-tools.spec.ts.
• Provider or production effects: None

Notes

• Supersedes the component-level px-3 sm:px-0 approach previously explored on this branch; fix(ui): balance mobile header new-chat edge inset #940 is the canonical phone header inset fix.
• Also replaces the leftover Mode-menu PR_POLICY_BODY.md from feat(ui): phone Mode menu opens as a bottom sheet #935 on this head so Sync applies this PR's description.

Summary by CodeRabbit

• Bug Fixes

  • Improved the mobile comparison dock’s responsiveness after scrolling, ensuring it reliably becomes tappable as it finishes its transition back into view.
  • Reduced intermittent tap/availability failures caused by animation timing during the dock’s reveal.

• Tests

  • Strengthened mobile UI interaction coverage by making the “dock ready before tapping” check more resilient to transition timing, helping prevent flaky CI runs.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The mobile compare-dock test now polls elementFromPoint during the reveal transition. The PR policy documents this scope, updates verification checks, records rollback details, and identifies the existing phone header fix as separate.

Changes

Compare dock timing

Layer / File(s)	Summary
Animated compare hit-test polling tests/ui-tools.spec.ts	The reveal-transition assertion repeatedly samples the compare element’s center until the element or a descendant is the pointer hit target.
Policy scope and verification PR_POLICY_BODY.md	The policy updates the compare-dock flake description, verification checklist, risk and rollback details, and notes that phone header spacing is unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• BigSimmo/Database#707: Updates synchronization in the same mobile compare-dock test.
• BigSimmo/Database#877: Adjusts geometry timing in the mobile compare tappability coverage.
• BigSimmo/Database#929: Modifies the same compare-dock reveal interaction assertion.

Suggested labels: codex

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: polling the compare-dock hit test after reveal transition.
Description check	✅ Passed	The description follows the required template with Summary, Verification, Risk and rollout, and Notes, and it is mostly complete.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/mobile-header-symmetry-5c1b

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

• Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #3742 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

[cursor]

Merge closeout

Blocked merge root cause: PR was CONFLICTING/DIRTY vs newer main (ledger conflicts with #942/#943, then #936 landed). Not a product CI failure — prior exact-head checks were green.

Fix: Clean rebuild on current main as plan-scoped 3-file diff (master-search-header.tsx Answer-mode px-3 sm:px-0, tests/ui-overlap.spec.ts symmetry proof, ledger row). DocumentViewer unchanged. No review threads to resolve.

Local verification on head dce0f27c: format/lint/typecheck clean; tests/ui-overlap.spec.ts 13/13.

Note: Integration token cannot undraft/edit PR body (403). Please mark ready once hosted CI is green.

[cursor]

Update: rebased onto #944

Branch rebuilt onto latest main including fix(ui): settle single search header before overlap checks (#944).

• Product change unchanged: Answer-mode px-3 sm:px-0 + phone inset symmetry test
• Local tests/ui-overlap.spec.ts 13/13 on head b66ec6fb (uses updated gotoHome with /?mode=answer + single header#search)
• Mergeable; waiting on hosted Production UI for exact-head green
• Still draft — token cannot undraft (403). Please mark ready after CI succeeds.

[cursor]

CI failure fix

Failed check: Production UI — mobile differential compare dock hides on scroll down and stays tappable when revealed (restoredPointer false at reveal).

Root cause: Timing flake — single elementFromPoint sample during dock reveal ease-in. Not caused by the header gutter change (local repro of the dock test passes; overlap suite 13/13 green).

Fix: Poll restoredPointer until the compare CTA receives hits after reveal (tests/ui-tools.spec.ts).

Waiting on exact-head hosted Production UI for this push (98cfb881).

[cursor]

Ready for merge (exact-head green)

Hosted CI: SUCCESS on f8c3e18f — Production UI, Build, Unit coverage, Static, PR required, Gitleaks all green. Mergeable=MERGEABLE, mergeStateStatus=CLEAN, contains latest main (#938/#944).

Product: Answer-mode phone header px-3 sm:px-0 + overlap symmetry proof.

CI fix included: poll compare-dock pointer hit after reveal (flaky elementFromPoint mid-transition).

Local: ui-overlap 13/13; compare-dock test pass.

Human step: PR is still draft (integration token cannot undraft/edit body — 403). Please Mark ready for review then merge. No unresolved review threads.

[coderabbitai]

🧹 Nitpick comments (1)

scripts/check-pr-policy-workflow.mjs (1)

108-110: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Make this workflow contract check semantic.

applyStep.includes("governanceAttested") can pass on a comment or dead code, without proving that detection, checklist application, and marker removal still work. Validate those behaviors with a template fixture or separate structural assertions.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/check-pr-policy-workflow.mjs` around lines 108 - 110, Replace the
substring-only check in the workflow contract validation with semantic coverage
of the GOVERNANCE_ATTESTED flow: verify detection, checklist application, and
removal of the optional template marker using a fixture or focused structural
assertions. Anchor the changes in the existing applyStep validation and preserve
failures for workflows that do not implement the complete behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@scripts/check-pr-policy-workflow.mjs`:
- Around line 108-110: Replace the substring-only check in the workflow contract
validation with semantic coverage of the GOVERNANCE_ATTESTED flow: verify
detection, checklist application, and removal of the optional template marker
using a fixture or focused structural assertions. Anchor the changes in the
existing applyStep validation and preserve failures for workflows that do not
implement the complete behavior.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f628af31-dc22-4392-b3b7-bce94870d237

📥 Commits

Reviewing files that changed from the base of the PR and between f8c3e18 and e51a58c.

📒 Files selected for processing (3)

• .github/workflows/ci.yml
• PR_POLICY_BODY.md
• scripts/check-pr-policy-workflow.mjs

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@PR_POLICY_BODY.md`:
- Around line 19-26: Update the checklist in PR_POLICY_BODY.md to require,
rather than mark not applicable, both production-readiness and
deployment-readiness checks for the administrator authorization, Supabase
migration, and ingestion-worker redeployment changes. Revise the Risk and
rollout statements to accurately include these auth, privacy/document-access,
database, and deployment effects, and expand the rollback plan to cover the
corresponding implementation and migration changes alongside the existing UI and
governance updates.

In `@scripts/check-pr-policy-workflow.mjs`:
- Around line 108-110: Strengthen the validation in the policy-checking flow
around the `applyStep` assertion so it verifies actual `GOVERNANCE_ATTESTED`
marker detection, governance-item handling, and marker removal, rather than only
checking for the `governanceAttested` identifier. Ensure comments or unrelated
references cannot satisfy the guard while attestation behavior is broken.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c5fe5bf6-7174-4023-a746-b377c02b9eef

📥 Commits

Reviewing files that changed from the base of the PR and between e51a58c and e504751.

📒 Files selected for processing (7)

• .github/workflows/ci.yml
• PR_POLICY_BODY.md
• docs/branch-review-ledger.md
• scripts/check-pr-policy-workflow.mjs
• src/components/clinical-dashboard/master-search-header.tsx
• tests/ui-overlap.spec.ts
• tests/ui-tools.spec.ts

🚧 Files skipped from review as they are similar to previous changes (5)

• src/components/clinical-dashboard/master-search-header.tsx
• docs/branch-review-ledger.md
• tests/ui-overlap.spec.ts
• tests/ui-tools.spec.ts
• .github/workflows/ci.yml

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@PR_POLICY_BODY.md`:
- Line 5: Update the policy summary, risk assessment, and rollback bullets in
PR_POLICY_BODY.md to accurately cover all PR changes: Answer-mode phone gutters,
the header symmetry assertion, and GOVERNANCE_ATTESTED CI sync handling. Remove
the claims that header spacing is unchanged or the change is test-only, and
ensure the rollback plan explicitly addresses each affected area.

🪄 Autofix (Beta)

❌ Autofix failed (check again to retry)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f3a3175-a894-4133-ab9e-dc85a83b7a1d

📥 Commits

Reviewing files that changed from the base of the PR and between e504751 and e2a758a.

📒 Files selected for processing (2)

• PR_POLICY_BODY.md
• tests/ui-tools.spec.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• tests/ui-tools.spec.ts

[cursor]

Closeout update

Product goal already landed on main via #940 (--header-edge-pad CSS token). That is the canonical phone header inset fix.

This PR was retargeted so it no longer changes header spacing (the earlier px-3 sm:px-0 approach would double-pad on top of #940).

Remaining delta on this head

• tests/ui-tools.spec.ts: poll elementFromPoint through the compare-dock reveal transition (hosted CI flake harden)
• PR_POLICY_BODY.md: accurate ready-state description for Sync

Status

• Required CI green on current head; PR Policy body synced; squash auto-merge enabled
• Still blocked on the required human approving review (agent cannot satisfy that)

If you only wanted the header symmetry fix, #940 already delivers it and this PR can be closed. If you want the compare-dock flake harden too, one approving review should let auto-merge finish.

[cursor]

Closing as finished: the phone header inset asymmetry was already fixed on main by #940 (--header-edge-pad).

This branch’s remaining delta was only a compare-dock Playwright poll harden, and merge stays blocked on the required human approving review. Not worth keeping open after the product fix landed.

If the compare-dock flake returns on hosted CI, re-open or cherry-pick tests/ui-tools.spec.ts from e2a758a1.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.