Skip to content

fix: align favourites empty-state colspan with compact columns#804

Merged
cursor[bot] merged 1 commit into
mainfrom
cursor/favourites-empty-colspan-40ad
Jul 17, 2026
Merged

fix: align favourites empty-state colspan with compact columns#804
cursor[bot] merged 1 commit into
mainfrom
cursor/favourites-empty-colspan-40ad

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • When the favourites item workspace is open, the Evidence column is hidden at every breakpoint.
  • Update the empty-state row so it spans five columns in that compact layout instead of incorrectly spanning six at 2xl.

Verification

  • npm run verify:pr-local — covered by CI Static PR checks on this PR
  • UI verification not run: colspan-only table markup change; CI Production UI gate covers smoke

Risk and rollout

  • Risk: low; favourites empty-state table markup only
  • Rollback: revert this PR to restore the previous empty-state colSpans
  • Provider or production effects: None

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Bug Fixes
    • Fixed the favourites table empty state when an item workspace is open so it now spans the correct number of columns.
    • The empty-state layout now correctly matches the compact vs full table view, including consistent Evidence-column visibility.

@supabase

supabase Bot commented Jul 17, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@cursor
cursor Bot enabled auto-merge (squash) July 17, 2026 21:44
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0528a3d7-47b6-45ef-9009-7c960ed3c65a

📥 Commits

Reviewing files that changed from the base of the PR and between 53ac762 and c0958c6.

📒 Files selected for processing (1)
  • src/components/clinical-dashboard/favourites-command-library-page.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/clinical-dashboard/favourites-command-library-page.tsx

📝 Walkthrough

Walkthrough

The favourites table empty state now adapts its column span and rendering key to the compact workspace layout while preserving existing full-layout breakpoint behavior.

Changes

Favourites table layout

Layer / File(s) Summary
Compact empty-state rendering
src/components/clinical-dashboard/favourites-command-library-page.tsx
The empty-state cell spans five columns in compact mode, retains the existing 2xl-based five/six-column behavior otherwise, and uses a layout-specific key.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the main change to the favourites empty-state colspan.
Description check ✅ Passed The description matches the template well, with summary, verification, risk, and governance sections completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/favourites-empty-colspan-40ad

Comment @coderabbitai help to get the list of available commands.

When the item workspace is open, Evidence is hidden at every breakpoint,
so the empty-state row must span five columns instead of six at 2xl.

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/favourites-empty-colspan-40ad branch from 53ac762 to c0958c6 Compare July 17, 2026 21:49
@cursor
cursor Bot merged commit 827c2f1 into main Jul 17, 2026
16 checks passed
@cursor
cursor Bot deleted the cursor/favourites-empty-colspan-40ad branch July 17, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants