Skip to content

fix: align favourites empty-state colspan with compact columns #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cursor merged 1 commit into from
Jul 17, 2026
+10 −6
Merged

fix: align favourites empty-state colspan with compact columns #804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/components/clinical-dashboard/favourites-command-library-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,12 +728,16 @@ function FavouritesTable({
})}
{tableRows.length === 0 ? (
<tr>
{/* The Evidence column is hidden below 2xl, so span 5 there and 6 at 2xl+. */}
{[
{ colSpan: 5, className: "px-4 py-10 text-center 2xl:hidden" },
{ colSpan: 6, className: "hidden px-4 py-10 text-center 2xl:table-cell" },
].map(({ colSpan, className }) => (
<td key={colSpan} colSpan={colSpan} className={className}>
{/* Compact (workspace open) always hides Evidence, so stay at 5 columns.
Otherwise Evidence appears only from 2xl, so span 5 below 2xl and 6 at 2xl+. */}
{(compact
? [{ colSpan: 5, className: "px-4 py-10 text-center" }]
: [
{ colSpan: 5, className: "px-4 py-10 text-center 2xl:hidden" },
{ colSpan: 6, className: "hidden px-4 py-10 text-center 2xl:table-cell" },
]
).map(({ colSpan, className }) => (
<td key={`${compact ? "compact" : "full"}-${colSpan}`} colSpan={colSpan} className={className}>
<Search className="mx-auto mb-2 h-5 w-5 text-[color:var(--text-soft)]" aria-hidden />
<p className="font-bold text-[color:var(--text-heading)]">No favourites match</p>
<p className="mt-1 text-sm font-semibold text-[color:var(--text-muted)]">
Expand Down