Fix mobile differentials search layout and FAB behavior#877
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe mobile differential compare action now uses dedicated FAB styling, safe-area positioning, and empty-state treatment. Search-results layout and initialization behavior were updated, with regression tests covering shell scrolling, horizontal overflow, and compare-action geometry. ChangesMobile differential compare interaction
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
CI triageCI failed on this PR. Automated classification of the 2 failed job(s):
Compared with main CI run #3362 (cancelled). Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger. |
…-differential-search Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
overflow-x-hidden on the results canvas forced overflow-y:auto under the flex height cap, nesting a scrollport that left #main-content at scrollTop 0 and broke the mobile compare FAB scroll regression. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
Closing as superseded by #886 (Fix mobile differentials search layout and FAB behavior). Preferring the newer Cursor PR with green CI. |
Motivation
Description
.differentials-mobile-compare-fab*insrc/app/globals.css.src/components/clinical-dashboard/differentials-home.tsx.lastResultSignatureso the top two diagnosis results are selected automatically.min-w-0, adjusting gaps/padding, and wrapping the source-status action to prevent horizontal overflow.tests/ui-tools.spec.tsto scroll the actual#main-contentscrollport and assert the FAB does not overlap the dock and that the page has no horizontal overflow.Testing
npm cisuccessfully with no vulnerabilities reported.npm run typecheck,npm run lint, andnpx prettier --checkwhich all completed successfully.git diff --checkand formatting checks; they passed and the changes were committed on branchworkasfix: polish mobile differentials search.npm run test:e2ebuild and localnpm run ensurebut the Playwright production build and local server startup failed in this environment because Next failed to fetch Google-hosted Geist fonts (external network-font fetch), so the e2e browser verification could not complete here.ensurerequire a network-enabled environment that allows fetching the Google fonts or local font provisioning before the full browser checks can be confirmed.Codex Task
Summary by CodeRabbit
New Features
Bug Fixes
Tests