-
Notifications
You must be signed in to change notification settings - Fork 0
test(ui): poll compare-dock pointer hit after reveal transition #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,29 @@ | ||
| ## Summary | ||
|
|
||
| - On phone viewports (`max-width: 639px`), the header Mode picker opens as the shared bottom `Sheet` so the full mode list is scrollable with backdrop dismiss, Escape, focus trap, and return-focus to the Mode button. | ||
| - Desktop (`sm:`+) keeps the existing anchored absolute dropdown, keyboard navigation, blur-leave dismiss, and outside-click dismiss via `useDismissableLayer`. | ||
| - Hardens shared `Sheet` backdrop dismiss (gesture must start on the dimmed area; no click-through) and Tab-trap handling for roving `tabindex="-1"` menus. | ||
| - Keeps PDF extractor process-tree termination reliable under suite load; Python binary resolution uses shared `python-bin` from main. | ||
| - Fixes phone hydration: Mode layout gate initializes SSR-safe and syncs from `matchMedia` after mount / on open (avoids React #418 on phone route coverage). | ||
| Hosted Production UI occasionally failed the differentials compare-dock tap assertion after scroll-reveal: a single `elementFromPoint` sample could miss while `translateY` was still easing. Poll the pointer-hit check through the reveal transition so the assertion waits for a stable hit target. | ||
|
|
||
| ## Verification | ||
| The original phone Answer header gutter asymmetry is already fixed on `main` by #940 (`--header-edge-pad`); this PR does not change header spacing. | ||
|
|
||
| - [x] Focused Vitest — header/sheet/audit-navigation contracts green after hydration fix | ||
| - [x] Mode Playwright proofs — phone sheet open/scroll/select, backdrop dismiss + focus restore, desktop outside-click (no sheet), keyboard nav (5/5) | ||
| - [x] Previously failing Production UI route-coverage journeys — DSM/specifier/differential phone hydration (3/3) | ||
| - [x] `npm run check:production-readiness:ci` — READY (no blocking failures) | ||
| - UI verification not run: full `verify:ui` / `verify:release` not required beyond the focused Mode + route-coverage proofs above | ||
| - Provider-backed live evals not run: no answer-generation or retrieval scoring changes | ||
| ## Verification | ||
|
|
||
| ## Risk and rollout | ||
| - [x] `npm run verify:pr-local` | ||
| - [x] `npm run verify:ui` when UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changed | ||
| - [ ] `npm run verify:release` before release or handoff confidence claims | ||
|
|
||
| - Risk: low — phone-only Mode open path plus shared Sheet dismiss/focus hardening; desktop Mode contracts preserved. Extractor change is fail-closed process cleanup only. | ||
| - Rollback: revert this PR; Mode menu returns to the previous floating phone panel and prior Sheet/extractor behaviour. | ||
| - Provider or production effects: None | ||
| UI verification: Chromium compare-dock test and prior full `verify:ui` on this branch lineage; hosted Production UI also passed after the poll harden on earlier heads. | ||
|
|
||
| ## Clinical Governance Preflight | ||
| - [ ] **`npm run eval:retrieval:quality` (must stay 36/36) when retrieval, ranking, selection, chunking, or scoring behavior changed** — not applicable | ||
| - [ ] `npm run eval:rag -- --limit 15` + `npm run eval:quality -- --rag-only` when answer generation, the synthesis prompt, or answer post-processing changed — not applicable | ||
| - [ ] `npm run check:production-readiness` when clinical workflow, privacy, environment, Supabase, source governance, or deployment behavior changed — not applicable | ||
| - [ ] `npm run check:deployment-readiness` when deployment startup, hosting, or rollout behavior changed — not applicable | ||
|
|
||
| Touched extractors/document.ts (fail-closed process-tree cleanup only). No answer, citation, source-governance, privacy, or document-access behaviour change. | ||
| ## Risk and rollout | ||
|
|
||
| <!-- GOVERNANCE_PREFLIGHT --> | ||
| - Risk: Low. Test-only wait hardening for a mid-transition pointer sample; no product behavior change. | ||
| - Rollback: Revert the compare-dock `expect.poll` change in `tests/ui-tools.spec.ts`. | ||
| - Provider or production effects: None | ||
|
|
||
| ## Notes | ||
|
|
||
| - Phone gate reuses `phoneSearchLayoutMediaQuery` (`max-width: 639px`). | ||
| - `id="app-mode-menu"` is preserved inside the sheet for existing restore-focus guards. | ||
| - Supersedes the component-level `px-3 sm:px-0` approach previously explored on this branch; #940 is the canonical phone header inset fix. | ||
| - Also replaces the leftover Mode-menu `PR_POLICY_BODY.md` from #935 on this head so Sync applies this PR's description. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.