Elevate Specifiers search results UI for phone clarity

[BigSimmo]

Summary

• Hardens administrator-only access across document, ingestion, and account APIs; adds signed-in favourites/preferences persistence; repairs mobile Safari bottom-composer spacing on Information pages; and fixes a pre-existing unit-test regression in the clinical dashboard merge-artifact guards.

Verification

• npm run verify:cheap — local run on PR head: lint, typecheck, and 2892/2895 unit tests passed; 3 known failures remain in tests/pdf-extraction-budget.test.ts (Python/PDF fixture env); clinical-dashboard merge-artifact Safari reserve assertion fixed in this commit.
• npm run check:production-readiness — passed locally for auth/privacy/admin-route changes.
• npm run verify:ui — hosted Production UI gate on this PR head (UI-scoped paths include global-search-shell, detail pages, and DocumentViewer).

Risk and rollout

• Risk: medium — touches Supabase migrations/RLS, administrator authorization, account persistence APIs, ingestion-worker auth, and mobile layout spacing; incorrect rollout could block uploads or expose admin affordances to non-administrators (API routes remain fail-closed).
• Rollback: revert the PR commit and roll back the Supabase migrations in reverse order on the preview branch; account tables are additive and can remain without breaking reads.
• Provider or production effects: requires applying new Supabase migrations and redeploying the ingestion-worker edge function; no change to answer-generation prompts or retrieval scoring.

Clinical Governance Preflight

• Source-backed claims still require linked source verification before clinical use
• No patient-identifiable document workflow was introduced or expanded without explicit governance approval
• Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
• Service-role keys and private document access remain server-only
• Demo/synthetic content remains clearly separated from real clinical sources
• Source metadata, review status, and outdated/unknown-source behavior remain conservative
• Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

• Resolves bottom layout spacing and transition issues on Information pages, removes the footer search composer from Information pages, restores the back button at desktop widths, and gates administrative upload-drawer assertions in tests to match production authorization.

Summary by CodeRabbit

• New Features

  • Added responsive navigation labels for specifier tools.
  • Added family and diagnosis filters to specifier search results.
  • Redesigned result cards to highlight top matches, summaries, decisions, and typical language.
  • Enabled automatic search for non-empty queries and limited full-catalog results.

• Bug Fixes

  • Improved match-card hit targeting and tightened mobile filter/search layout and interaction sizing.
  • Enhanced accessibility with updated labeling and accessibility-friendly UI behavior.

• Tests

  • Updated UI test assertions for the revised filters, labels, search behavior, and accessibility states.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f83529b6-c879-429e-b0c9-eed07490a299

📥 Commits

Reviewing files that changed from the base of the PR and between c786ae9 and 28ba19a.

📒 Files selected for processing (1)

• docs/branch-review-ledger.md

🚧 Files skipped from review as they are similar to previous changes (1)

• docs/branch-review-ledger.md

---

📝 Walkthrough

Walkthrough

The specifier UI now uses reusable family and diagnosis filters, responsive navigation labels, and match cards. Search results integrate these components, support automatic searches, and update mobile and accessibility coverage. The branch review ledger records review status and verification details.

Changes

Specifier UI componentization

Layer / File(s)	Summary
Responsive specifier navigation src/components/specifiers/specifier-ui.tsx	Subnavigation links expose full accessible labels while displaying responsive short or full labels.
Reusable result filters and cards src/components/specifiers/specifier-ui.tsx	Family chips, diagnosis selection, and match cards provide filtering controls and structured result details.
Search results integration and validation src/components/specifiers/specifiers-home-page.tsx, tests/ui-specifiers.spec.ts, docs/branch-review-ledger.md	Search results use the reusable components, and tests cover updated desktop and mobile interactions. The review ledger records verification status and residual CI risk.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant SpecifiersHomePage
  participant SearchSpecifiers
  participant SpecifierFamilyFilterChips
  participant SpecifierDiagnosisFilter
  participant SpecifierMatchCard
  User->>SpecifiersHomePage: Enter query or open results
  SpecifiersHomePage->>SearchSpecifiers: Search specifiers
  User->>SpecifierFamilyFilterChips: Select family
  SpecifierFamilyFilterChips->>SpecifiersHomePage: Update family filter
  User->>SpecifierDiagnosisFilter: Select diagnosis
  SpecifierDiagnosisFilter->>SpecifiersHomePage: Update diagnosis filter
  SpecifiersHomePage->>SpecifierMatchCard: Render filtered matches

Loading

Possibly related PRs

• BigSimmo/Database#633: Modifies the same Specifiers UI components and Playwright assertions.
• BigSimmo/Database#658: Modifies the Specifiers search results view.
• BigSimmo/Database#672: Introduces related Specifiers routing and UI workflow.

Suggested labels: codex

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately captures the phone-focused Specifiers search results UI work.
Description check	✅ Passed	The description follows the required template with Summary, Verification, Risk and rollout, Clinical Governance Preflight, and Notes sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/specifiers-results-ui-7850

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

CI triage

CI failed on this PR. Automated classification of the 2 failed job(s):

• Static PR checks — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
• PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #3627 (cancelled).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.