Skip to content

fix(ui): settle single search header before overlap checks #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cursor merged 3 commits into from
Jul 19, 2026
Merged

fix(ui): settle single search header before overlap checks #944

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f0bdab
fix(ui): settle single search header before overlap checks
cursoragent Jul 19, 2026
df7bd6e
Merge origin/main into ui-overlap header settle fix
cursoragent Jul 19, 2026
418de1b
Merge origin/main to unblock squash auto-merge
cursoragent Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/ui-overlap.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,14 @@ async function mockDemoDashboard(page: Page) {
}

async function gotoHome(page: Page) {
await page.goto("/", { waitUntil: "domcontentloaded" });
// Pin mode=answer so GlobalSearchShell does not immediately router.replace()
// for a stored landing preference. That replace can briefly leave two mounted
// shells (and two header#search nodes), which trips Playwright strict mode.
await page.goto("/?mode=answer", { waitUntil: "domcontentloaded" });
// Wait until React settles on a single header. During client remount /
// hydration a second transient header#search can exist briefly and trip
// Playwright strict mode even though the stable tree has only one banner.
// Permanent double-render still fails toHaveCount(1).
const header = page.locator("header#search");
await expect(header).toHaveCount(1, { timeout: 30_000 });
await header.waitFor({ state: "visible", timeout: 30_000 });
Expand Down