fix(ui): settle single search header before overlap checks

[BigSimmo]

Summary

Hardens tests/ui-overlap.spec.ts gotoHome so Production UI cannot flake on a transient dual header#search during the home landing-preference router.replace.

Main already waits for a single banner (from #934). This PR adds the missing root-cause pin: navigate to /?mode=answer so GlobalSearchShell skips the preference redirect that reintroduces two banners.

Root cause (from CI triage on #936)

1. Production UI — locator('header#search') strict-mode violation (2 elements) while the shell applied a stored landing preference.
2. PR required — cascade from Production UI failure.

Fix

• Keep main's toHaveCount(1) settle.
• Pin /?mode=answer so landing preference cannot router.replace mid-setup.

Verification

• npm run verify:pr-local -- --files tests/ui-overlap.spec.ts — runtime/format/lint/typecheck/unit (2961 passed) + RAG fixtures
• node scripts/run-playwright.mjs tests/ui-overlap.spec.ts --project=chromium → 12/12
• UI verification not run: full verify:ui not required for a test-only helper change; hosted Production UI on this PR covers the suite.
• Clinical governance N/A (test-only, no clinical/privacy/source/env changes).

Risk and rollout

• Risk: Low — test helper only; assert still fails closed on a permanent double header.
• Rollback: Revert the commit.
• Provider or production effects: None

  

Summary by CodeRabbit

• Tests
  • Updated UI navigation coverage to load the answer mode explicitly.
  • Improved test stability by preventing duplicate header and search instances during page initialization.

[supabase]

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[coderabbitai]

📝 Walkthrough

Walkthrough

The Playwright gotoHome helper now navigates to /?mode=answer and waits for domcontentloaded before checking the single visible search header.

Changes

UI navigation test

Layer / File(s)	Summary
Pin home navigation mode tests/ui-overlap.spec.ts	gotoHome uses /?mode=answer with waitUntil: "domcontentloaded" and documents the duplicate-mount scenario it avoids.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• BigSimmo/Database#938: Updates the related gotoHome helper to address header and routing overlap failures.
• BigSimmo/Database#473: Changes behavior for the searchMode === "answer" home-page rendering path.

Suggested labels: codex

Suggested reviewers: cursoragent

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly matches the main change: pinning the UI test to avoid transient overlapping search headers.
Description check	✅ Passed	The description follows the template with Summary, Verification, and Risk/Rollout details, and notes the relevant gates.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/fix-ui-overlap-duplicate-header-3eab

---

_{Comment @coderabbitai help to get the list of available commands.}