Catch the bad status line exception and log it#239
Merged
Conversation
Collaborator
I would suggest just adding: |
Collaborator
Author
Changed and pushed. |
Collaborator
|
Looks good to me, a bit of testing and it can be merged. |
chfast
reviewed
Feb 21, 2017
| exit(1) | ||
| elif 'timed out' in ex.message: | ||
| print "Timed out, will retry in " + str(Lending.get_sleep_time()) + "sec" | ||
| elif isinstance(ex, BadStatusLine): |
There was a problem hiding this comment.
Should it go as a except BadStatusLine:?
Collaborator
There was a problem hiding this comment.
It could, but then we would need to duplicate the entire error logic that is in except Exception: already. (i.e. logging, status persisting, sleep)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polo sometimes return a bad error code we can't parse. This catches that exception.
Description
Fixes #205
TESTING STAGE
Tested
Types of changes
Checklist: