Skip to content

Catch the bad status line exception and log it #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnevet merged 2 commits into from
Feb 21, 2017
Merged

Catch the bad status line exception and log it #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f58032a
Catch the bad status line exception and log it
laxdog Feb 21, 2017
d691695
Move to main exception section
laxdog Feb 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lendingbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import sys
import time
import traceback
from httplib import BadStatusLine

from decimal import Decimal

Expand Down Expand Up @@ -94,6 +95,8 @@
exit(1)
elif 'timed out' in ex.message:
print "Timed out, will retry in " + str(Lending.get_sleep_time()) + "sec"
elif isinstance(ex, BadStatusLine):

@chfast chfast Feb 21, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it go as a except BadStatusLine:?

@rnevet rnevet Feb 21, 2017 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, but then we would need to duplicate the entire error logic that is in except Exception: already. (i.e. logging, status persisting, sleep)

print "Caught BadStatusLine exception from Poloniex, ignoring."
else:
print traceback.format_exc()
print "Unhandled error, please open a Github issue so we can fix it!"
Expand Down