BL-13496 #2: Fix transparency when you initially add a line drawing to cover page - #6505
Conversation
JohnThomson
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hatton)
src/BloomExe/Edit/EditingModel.cs line 1482 at r1 (raw file):
*/ SaveNow();
SaveNow is gone. This will have to be rethought using SaveThen().
Note, if you want, you can pass the argument that makes the action responsible for the SaveToDisk, but not do it. That way the picture gets into the DOM (and hopefully made transparent if it needs to be) but without taking time to actually save to disk.
7bb04e5 to
12cf57e
Compare
hatton
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @JohnThomson)
src/BloomExe/Edit/EditingModel.cs line 1482 at r1 (raw file):
Previously, JohnThomson (John Thomson) wrote…
SaveNow is gone. This will have to be rethought using SaveThen().
Note, if you want, you can pass the argument that makes the action responsible for the SaveToDisk, but not do it. That way the picture gets into the DOM (and hopefully made transparent if it needs to be) but without taking time to actually save to disk.
Done.
JohnThomson
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hatton)
This change is