Skip to content

BL-13496 #2: Fix transparency when you initially add a line drawing to cover page - #6505

Merged
JohnThomson merged 1 commit into
masterfrom
BL-13496FixTransparent
Jun 12, 2024
Merged

BL-13496 #2: Fix transparency when you initially add a line drawing to cover page#6505
JohnThomson merged 1 commit into
masterfrom
BL-13496FixTransparent

Conversation

@hatton

@hatton hatton commented May 23, 2024

Copy link
Copy Markdown
Member

This change is Reviewable

@JohnThomson JohnThomson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hatton)


src/BloomExe/Edit/EditingModel.cs line 1482 at r1 (raw file):

                 */

                SaveNow();

SaveNow is gone. This will have to be rethought using SaveThen().
Note, if you want, you can pass the argument that makes the action responsible for the SaveToDisk, but not do it. That way the picture gets into the DOM (and hopefully made transparent if it needs to be) but without taking time to actually save to disk.

@hatton
hatton force-pushed the BL-13496FixTransparent branch from 7bb04e5 to 12cf57e Compare June 6, 2024 23:57

@hatton hatton left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @JohnThomson)


src/BloomExe/Edit/EditingModel.cs line 1482 at r1 (raw file):

Previously, JohnThomson (John Thomson) wrote…

SaveNow is gone. This will have to be rethought using SaveThen().
Note, if you want, you can pass the argument that makes the action responsible for the SaveToDisk, but not do it. That way the picture gets into the DOM (and hopefully made transparent if it needs to be) but without taking time to actually save to disk.

Done.

@JohnThomson JohnThomson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @hatton)

@JohnThomson
JohnThomson merged commit 52215a9 into master Jun 12, 2024
@JohnThomson
JohnThomson deleted the BL-13496FixTransparent branch June 12, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants