Replace MessageEvent with ajax call in reader setup - #2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
If intentionally leaving this in, perhaps a comment about why this is bad (slow)? I guess the comment belongs in the .ts file, actually.
phillip-hopper
force-pushed
the
RemoveMessageEvent1
branch
from
October 6, 2014 18:34
3946901 to
00c7fdc
Compare
andrew-polk
added a commit
that referenced
this pull request
Oct 6, 2014
Replace MessageEvent with ajax call in reader setup
This was referenced Oct 26, 2018
jsubloom
pushed a commit
to jsubloom/BloomDesktop
that referenced
this pull request
Dec 7, 2018
jsubloom
pushed a commit
to jsubloom/BloomDesktop
that referenced
this pull request
Jan 25, 2019
jsubloom
pushed a commit
to jsubloom/BloomDesktop
that referenced
this pull request
Feb 12, 2019
Talking Book Per Text Box: refactoring Talking Book Per Text Box: More refactoring Talking Book Per Text Box: Code Review updates Talking Book Per Text Box: Code Review Fixes BloomBooks#2 Talking Book Per Text Box: Improve unit test coverage Talking Book Per Text Box: Code review changes Talking Book Per Text Box: More Code Review Fixes
jsubloom
pushed a commit
to jsubloom/BloomDesktop
that referenced
this pull request
Feb 12, 2019
Talking Book Per Text Box: refactoring Talking Book Per Text Box: More refactoring Talking Book Per Text Box: Code Review updates Talking Book Per Text Box: Code Review Fixes BloomBooks#2 Talking Book Per Text Box: Improve unit test coverage Talking Book Per Text Box: Code review changes Talking Book Per Text Box: More Code Review Fixes Talking Book Per Text Box: Modify updateCurrentDivAsync
hatton
added a commit
that referenced
this pull request
May 23, 2024
hatton
added a commit
that referenced
this pull request
Jun 6, 2024
hatton
added a commit
that referenced
this pull request
Jun 26, 2026
#7949) Code changes responding to the PR review: - Team Collections (review #1/#3/#4/#13): BloomBridge's mutating external endpoints (add/update/process-book) now fail fast on a Team Collection rather than silently corrupting a shared collection (they don't honor checkout, the TeamCollection.status file, or TC renames). Adds CollectionModel.IsEditableCollectionATeamCollection and ExternalApi.RefuseIfTeamCollection, and documents the non-TC assumption on CollectionModel.AddBookFromFolder. - Off-screen JS bridge cleanup (#6/#7/#8) in BookProcessor: the capture trigger is now fire-and-forget (its result was discarded), the redundant Application.DoEvents() in the poll loop is removed (the sync call already pumps the loop), and WaitForJavascriptResult documents why the off-screen processor keeps the poll-a-window-global approach rather than the live editor's async API callback. - Async page-readiness (#10/#11/#15): SetImageDisplaySizeIfCalledFor now registers a requestPageContent delay around its asynchronous image-info fetch and resize, so captureContentForExternalProcessing waits for image sizing to finish before capturing. Corrects the editablePage.ts comments that wrongly called the load-time fix-ups "synchronous", and clarifies the natural-size fallback in autoFitImageOverTextSplits. - autoFit overlays (#14): fitOneImageOverTextSplit now also skips pages whose top pane has non-text overlays (canvas elements other than the background image), not just text overlays. - Smaller comment fixes: clarify the "already in the collection" guard in AddBookFromFolder (#2); document that the process-book overlay message is intentionally not localized (#12); note that priorForeground is captured once on purpose (#5); move the JSON-vs-delimiter note next to the code it describes (#16); raise the ExternalBusyOverlay z-index (#17). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hatton
added a commit
that referenced
this pull request
Jun 27, 2026
devin-review: automates reading Devin AI findings from app.devin.ai (Bugs + Investigate flags) and posting them as GitHub PR comments via gh CLI. The "Post to GitHub" button on Devin's site is non-functional, so the skill always uses gh. Informational/resolved items are skipped. pr-ready-for-human: full checklist for moving a PR to human review -- ensures committed+pushed, PR exists, YouTrack linked, GitHub project board updated (project #2 hardcoded IDs included), Devin review run, CI green, then sets Orca + GitHub board to the human-review columns. Also handles re-entry after new commits (restarts bot-wait cycle). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JohnThomson
added a commit
that referenced
this pull request
Jul 15, 2026
… green 460/460; batch-2 partial, uncompiled; vitest failure untriaged) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JohnThomson
added a commit
that referenced
this pull request
Jul 16, 2026
…est failures are pre-existing talkingBook) C# tree compiles (pause note's "may not compile" was unfounded); fixed the one real break (4 CloudBookTransferTests call sites missing the new localManifest arg). vitest's 5 failures are all in the untouched talkingBook audio spec (pre-existing/environmental). eslint on changed files clean after 3 fixes. Code fixes left uncommitted with the rest of the WIP per this batch's pattern, fully reproducible from the progress-log entry. Paused for scope confirmation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated gitignore