Initial Qrcode implementation based on JT's interregnum work

[StephenMcConnel]

---

---

This change is 

[StephenMcConnel]

@StephenMcConnel resolved 5 discussions.
Reviewable status: 0 of 19 files reviewed, all discussions resolved.

[StephenMcConnel]

@StephenMcConnel made 3 comments.
Reviewable status: 0 of 19 files reviewed, 3 unresolved discussions (waiting on andrew-polk and hatton).

[hatton]

@hatton partially reviewed 13 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: 13 of 22 files reviewed, 4 unresolved discussions (waiting on andrew-polk and StephenMcConnel).

---

src/BloomExe/Book/Book.cs line 5346 at r11 (raw file):

        {
            Storage.UpdateSupportFiles();
            BookStorage.UpdateQrCode(

Looking at the parameters here: is it intentional that we are giving it CollectionSettings but also giving it things that are derived from that same object ( CollectionSettings.ShowBlorgLanguageQrCode,
Language1Tag,)?

E.g. two options:

1. just give it CollectionSettings, don't require the Book.cs to know what it needs
2. Give it only what it needs: instead of CollectionSettings, give it CollectionSettings.BadgeQrCodeLabelLocalized

---

src/content/branding/branding-base.less line 95 at r11 (raw file):

    }
    .bloom-lang-on-blorg {
        font-size: smaller;

Just checking: is smaller really what you want? That makes it relative to some other declaration in a way that I don't know... is that good or bad?

[hatton]

@hatton resolved 1 discussion.
Reviewable status: 13 of 22 files reviewed, 3 unresolved discussions (waiting on andrew-polk and StephenMcConnel).

[StephenMcConnel]

@StephenMcConnel made 2 comments.
Reviewable status: 13 of 22 files reviewed, 3 unresolved discussions (waiting on andrew-polk and hatton).

---

src/BloomExe/Book/Book.cs line 5346 at r11 (raw file):

Previously, hatton (John Hatton) wrote…

Looking at the parameters here: is it intentional that we are giving it CollectionSettings but also giving it things that are derived from that same object ( CollectionSettings.ShowBlorgLanguageQrCode,
Language1Tag,)?

E.g. two options:

1. just give it CollectionSettings, don't require the Book.cs to know what it needs
2. Give it only what it needs: instead of CollectionSettings, give it CollectionSettings.BadgeQrCodeLabelLocalized

Done (#2)

---

src/content/branding/branding-base.less line 95 at r11 (raw file):

Previously, hatton (John Hatton) wrote…

Just checking: is smaller really what you want? That makes it relative to some other declaration in a way that I don't know... is that good or bad?

It's relative to the inherited font-size of 1em (which was essentially 10pt). I've changed it to 9pt (which is very slightly bigger than what the "smaller" keyword produced).

[StephenMcConnel]

@StephenMcConnel made 1 comment.
Reviewable status: 10 of 22 files reviewed, 3 unresolved discussions (waiting on andrew-polk and hatton).

---

src/BloomExe/Book/Book.cs line 5346 at r11 (raw file):

Previously, StephenMcConnel (Steve McConnel) wrote…

Done (#2)

Reviewable did something strange with my attempt to indicate that I used option number 2.

[hatton]

@hatton reviewed 3 files and resolved 3 discussions.
Reviewable status: 13 of 22 files reviewed, all discussions resolved (waiting on andrew-polk).