L200 up to 6.2.1.6#37
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
- feat(L200): add envelope roof tests
- feat(L200): add envelope wall tests
- feat(L200): add envelope fenestration tests
- feat(L200): add foundation system tests
- feat(L200): add tightness tests
- feat(L200): fix MMBtu units for NG ResourceUse
- feat(L200): test HVAC systems year installed
- feat(L200): add capacity and condition tests
- feat(L200): add central plant tests
- feat(L200): add air distribution tests
- feat(L200): add outdoor air delivery tests
- feat(L200): add duct condition tests
- feat(L200): add plant pump tests
- feat(L200): add hvac controls tests
- feat(L200): add hvac zone controls tests
- feat(L200): add BAS tests
- feat(L200): tie up remaining HVAC loose ends
corymosiman12
suggested changes
Oct 19, 2020
Contributor
corymosiman12
left a comment
corymosiman12
left a comment
There was a problem hiding this comment.
So close Ted! Minor changes now.
feat(eems): more realistic EEMs
Also, tweaks calculations for AnnualEnergyUse to only look at meters linked to utilities (ie not submeter)
| <auc:ThermalZoneLayout>Single zone</auc:ThermalZoneLayout> | ||
| </auc:Section> | ||
| <auc:Section ID="Section-Space-B"> | ||
| <auc:SectionType>Component</auc:SectionType> |
| <auc:DuctSystem ID="DuctSystem-A"> | ||
| <auc:DuctConfiguration>Single</auc:DuctConfiguration> | ||
| <auc:DuctInsulationCondition>Excellent</auc:DuctInsulationCondition> | ||
| <auc:HeatingDeliveryID IDref="Delivery-A"/> |
Contributor
There was a problem hiding this comment.
also add auc:CoolingDeliveryID
| <auc:FanSystems> | ||
| <auc:FanSystem ID="FanSystem-A"> | ||
| <auc:FanControlType>Stepped</auc:FanControlType> | ||
| <auc:LinkedSystemIDs> |
Contributor
There was a problem hiding this comment.
For fans, I think we should also require:
- FanEfficiency
- FanSize
- InstalledFlowRate [WARNING]
Contributor
There was a problem hiding this comment.
Can we also add a PR to the schema to:
- deprecate FanSize
- Add
FanMaximumFlowRate(to mirror the pump). This is replacing FanSize. Assuming that gets approved, change the above to requireFanMaximumFlowRateinstead ofFanSize
Contributor
There was a problem hiding this comment.
Also, to mirror pump, change InstalledFlowRate -> FanInstalledFlowRate
Contributor
Author
There was a problem hiding this comment.
First part addressed here: ca9a4ca
I think we should punt on adding these new elements for now and just get this PR merged, then tweak as we need to later.
corymosiman12
suggested changes
Oct 22, 2020
Contributor
corymosiman12
left a comment
corymosiman12
left a comment
There was a problem hiding this comment.
K ted, minor things.
Also, we have gotten some initial feedback on the occupancytype enumerations spreadsheet, so maybe we can update that as well. I will email that to you.
corymosiman12
approved these changes
Oct 23, 2020
Contributor
corymosiman12
left a comment
corymosiman12
left a comment
There was a problem hiding this comment.
Assuming tests on Travis pass, good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.