Skip to content

docs(schema): add deprecation warning for Delivery Capacity#258

Merged
macintoshpie merged 1 commit into
developfrom
docs/delivery-capacity
Oct 21, 2020
Merged

docs(schema): add deprecation warning for Delivery Capacity#258
macintoshpie merged 1 commit into
developfrom
docs/delivery-capacity

Conversation

@macintoshpie
Copy link
Copy Markdown
Contributor

Per discussion here BuildingSync/TestSuite#37 (comment)

It doesn't make sense to have Delivery capacity when the linked systems (fan, heating, cooling) have capacities of their own.

Copy link
Copy Markdown
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the deprecation warning include a version, e.g., "This element is being deprecated in version X.Y.Z, use ..."?

Copy link
Copy Markdown
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation policy discussed during weekly standup meeting. To be added in new PR.

Changes in PR are approved.

@markborkum
Copy link
Copy Markdown
Contributor

New PR to add deprecation policy: #261

@macintoshpie macintoshpie merged commit be3587f into develop Oct 21, 2020
@macintoshpie macintoshpie deleted the docs/delivery-capacity branch October 21, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants