Skip to content

fix: harden Java SDK publish + javadoc links#317

Merged
pratyush618 merged 2 commits into
masterfrom
fix/java-publish-robustness
Jun 27, 2026
Merged

fix: harden Java SDK publish + javadoc links#317
pratyush618 merged 2 commits into
masterfrom
fix/java-publish-robustness

Conversation

@pratyush618

@pratyush618 pratyush618 commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Two fixes surfaced by the 0.17.0 Maven Central publish attempt.

  • Javadoc links: {@link Queue#listJobs(JobFilter)} / {@link Queue#worker()} could not resolve Queue from the model/worker packages (no import). Fully-qualified both refs — clears the javadoc warnings in the publish run.
  • Idempotent tag step: a workflow_dispatch re-publish of the same version died on git tag java-v0.17.0 (tag already on remote). Guarded with git ls-remote, mirroring the existing GitHub-release step.

Note: neither caused the FAILED deployment — that was the GPG public key missing from keyservers (operational, fixed separately by uploading the key).

Summary by CodeRabbit

  • Bug Fixes

    • Improved Java release publishing so tag creation is skipped when the tag already exists, helping workflow re-runs complete more reliably.
  • Documentation

    • Updated Java API documentation links for clearer navigation between related classes and methods.

@github-actions github-actions Bot added the ci label Jun 27, 2026
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 01ec80ae-cc32-45f5-928e-f6566524734f

📥 Commits

Reviewing files that changed from the base of the PR and between ec276b8 and 77a76eb.

📒 Files selected for processing (3)
  • .github/workflows/publish-java.yml
  • sdks/java/src/main/java/org/byteveda/taskito/model/JobFilter.java
  • sdks/java/src/main/java/org/byteveda/taskito/worker/Worker.java

📝 Walkthrough

Walkthrough

The Maven Central publish workflow's "Create git tag" step is made idempotent by checking for an existing remote tag before creating and pushing it. Two Javadoc {@link} references in JobFilter and Worker are updated to use fully-qualified org.byteveda.taskito.Queue type names.

Changes

Publish Workflow & Javadoc Fixes

Layer / File(s) Summary
Idempotent git tag step
.github/workflows/publish-java.yml
Uses git ls-remote to check if java-v${VERSION} already exists on the remote; skips tag creation and push if found, otherwise proceeds as before.
Fully-qualified Javadoc links
sdks/java/.../model/JobFilter.java, sdks/java/.../worker/Worker.java
{@link Queue#listJobs(JobFilter)} and {@link Queue#worker()} references are updated to use the fully-qualified org.byteveda.taskito.Queue class name.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny once tagged the same branch twice,
And the workflow complained — not very nice!
Now it checks with a peek, ls-remote style,
And skips if the tag's been there a while. 🐇
Javadoc links? Fully qualified, hooray!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: Java SDK publish workflow hardening and Javadoc link fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/java-publish-robustness

Comment @coderabbitai help to get the list of available commands.

@pratyush618
pratyush618 merged commit 50c6279 into master Jun 27, 2026
20 checks passed
@pratyush618
pratyush618 deleted the fix/java-publish-robustness branch June 27, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant