fix: harden Java SDK publish + javadoc links#317
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe Maven Central publish workflow's "Create git tag" step is made idempotent by checking for an existing remote tag before creating and pushing it. Two Javadoc ChangesPublish Workflow & Javadoc Fixes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Two fixes surfaced by the 0.17.0 Maven Central publish attempt.
{@link Queue#listJobs(JobFilter)}/{@link Queue#worker()}could not resolveQueuefrom themodel/workerpackages (no import). Fully-qualified both refs — clears the javadoc warnings in the publish run.workflow_dispatchre-publish of the same version died ongit tag java-v0.17.0(tag already on remote). Guarded withgit ls-remote, mirroring the existing GitHub-release step.Note: neither caused the FAILED deployment — that was the GPG public key missing from keyservers (operational, fixed separately by uploading the key).
Summary by CodeRabbit
Bug Fixes
Documentation