Skip to content

fix: harden Java SDK publish + javadoc links #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pratyush618 merged 2 commits into from
Jun 27, 2026
Merged

fix: harden Java SDK publish + javadoc links #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f0f195
docs: fully-qualify Queue javadoc links in Java SDK
pratyush618 Jun 27, 2026
77a76eb
ci: make java publish git tag step idempotent
pratyush618 Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/publish-java.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,15 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
git tag "java-v${VERSION}"
git -c http.https://github.com/.extraheader="AUTHORIZATION: bearer ${GH_TOKEN}" \
push origin "java-v${VERSION}"
# Idempotent: a re-publish (e.g. after fixing the keyserver) reuses the
# same version, so skip if the tag is already on the remote.
if git ls-remote --exit-code --tags origin "java-v${VERSION}" >/dev/null 2>&1; then
echo "::notice::Tag java-v${VERSION} already exists — skipping"
else
git tag "java-v${VERSION}"
git -c http.https://github.com/.extraheader="AUTHORIZATION: bearer ${GH_TOKEN}" \
push origin "java-v${VERSION}"
fi

- name: Create GitHub release
if: ${{ !inputs.dry-run }}
Expand Down
2 changes: 1 addition & 1 deletion sdks/java/src/main/java/org/byteveda/taskito/model/JobFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;

/** Immutable filter for {@link Queue#listJobs(JobFilter)}. Unset fields are ignored. */
/** Immutable filter for {@link org.byteveda.taskito.Queue#listJobs(JobFilter)}. Unset fields are ignored. */
@JsonInclude(JsonInclude.Include.NON_NULL)
public final class JobFilter {
@JsonProperty("status")
Expand Down
2 changes: 1 addition & 1 deletion sdks/java/src/main/java/org/byteveda/taskito/worker/Worker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import org.byteveda.taskito.workflows.WorkflowTracker;

/**
* A running worker. Build one with {@link Queue#worker()}, register handlers,
* A running worker. Build one with {@link org.byteveda.taskito.Queue#worker()}, register handlers,
* then {@link Builder#start()}. {@link #close()} stops it and drains in-flight
* jobs.
*/
Expand Down