Skip to content

Update AmazonProductFeeEstimate.php#147

Merged
Peardian merged 4 commits into
CPIGroup:masterfrom
luigel:patch-1
Jan 19, 2018
Merged

Update AmazonProductFeeEstimate.php#147
Peardian merged 4 commits into
CPIGroup:masterfrom
luigel:patch-1

Conversation

@luigel
Copy link
Copy Markdown
Contributor

@luigel luigel commented Jan 16, 2018

Edited the option key for the listing prices so the amazon can get the data. Refer to the scratchpad product api labels.

Peardian and others added 2 commits November 17, 2017 12:59
Edited the option key for the listing prices so the amazon can get the data. Refer to the scratchpad product api labels.
@Peardian Peardian changed the base branch from stable to master January 16, 2018 15:19
@Peardian Peardian added the bug label Jan 16, 2018
@Peardian
Copy link
Copy Markdown
Collaborator

Looks like I messed up the option names when adding that class. Thanks for the finding and fixing it!

Would you mind also fixing the AmazonProductFeeEstimateTest unit test real quick to make Travis happy? The test is expecting the old option names, so fixing it would be as easy as swapping in the new names. I would greatly appreciate it if you could. If not, I understand. I can fix it on my own if needbe.

luigel added a commit to luigel/phpAmazonMWS that referenced this pull request Jan 17, 2018
Updated unit test for the CPIGroup#147 
Good day!
@Peardian Peardian mentioned this pull request Jan 17, 2018
@Peardian
Copy link
Copy Markdown
Collaborator

@luigel Thank you for combining the merge requests. As you can see, you simply need to push the changes to your patch-1 branch to update the pull request.

It looks like the one unit test is still failing. Could you try fixing it again? If it proves to be too difficult for you, I can try fixing them myself on Friday.

@luigel
Copy link
Copy Markdown
Contributor Author

luigel commented Jan 18, 2018

@Peardian Sorry I tried to fixed it in my latest push in the patch-1. Can you try it if it is now working. If not I would like your help for it. Thank you. Good day.

@Peardian
Copy link
Copy Markdown
Collaborator

Thank you! The tests pass now, so there will be no problem in merging it. I should have it merged by the end of the week. Thank you for your contribution!

@Peardian Peardian merged commit f2dcfa7 into CPIGroup:master Jan 19, 2018
@luigel luigel deleted the patch-1 branch January 20, 2018 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants