Skip to content

Update AmazonProductFeeEstimateTest.php#148

Closed
luigel wants to merge 2 commits into
CPIGroup:masterfrom
luigel:patch-2
Closed

Update AmazonProductFeeEstimateTest.php#148
luigel wants to merge 2 commits into
CPIGroup:masterfrom
luigel:patch-2

Conversation

@luigel
Copy link
Copy Markdown
Contributor

@luigel luigel commented Jan 17, 2018

Updated unit test for the #147
Good day!

Peardian and others added 2 commits November 17, 2017 12:59
Updated unit test for the CPIGroup#147 
Good day!
@Peardian Peardian changed the base branch from stable to master January 17, 2018 14:53
@Peardian
Copy link
Copy Markdown
Collaborator

Thank you for fixing the unit test. I very much appreciate it.

Could you merge this branch into your patch-1 branch, rather than having it separate? The tests will only work correctly if the changes from both branches are combined.

@luigel
Copy link
Copy Markdown
Contributor Author

luigel commented Jan 17, 2018

@Peardian Sorry i don't know how to add it in the patch-1 branch. Can you help me how? thanks

@Peardian Peardian closed this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants