Add histogram selection + time info for torque time-series widget#855
Merged
Add histogram selection + time info for torque time-series widget#855
Conversation
added 6 commits
November 25, 2015 11:43
Renders hour + date of current step
Contributor
|
It looks really cool! |
8 tasks
Contributor
Author
|
Torque.js 2.14.0 was just released, with updated dependency version the tests pass as expected too 🎉 |
Contributor
Author
There was a problem hiding this comment.
I'll make the real icons in the next PR as part of doing the CSS etc. 😉
Contributor
There was a problem hiding this comment.
oh, no problem, I just loved the temporary idea :)
Contributor
|
👍 awesome job |
viddo
added a commit
that referenced
this pull request
Nov 25, 2015
Add histogram selection + time info for torque time-series widget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waypoint for #786
This PR adds:
Basically just minor view changes, although had to modify the torque layer model slightly to handle events properly (for steps/range changes.
Also notice that this PR depends on having a new minor version of torque.js, these changes are using CartoDB/torque#243 for now I'm testing with a local checkout of that repo and using
npm linkto verify the changes working for this branch.@javierarce can you review?
cc @javisantana for torque layer model changes