Merged
Conversation
This was referenced Nov 24, 2015
lib/torque/animator.js
Outdated
Contributor
There was a problem hiding this comment.
it's hard to follow when the class is named "AnimatorStepsRange" internally and "StepsRange" here
Contributor
Author
There was a problem hiding this comment.
Good point, I'll rename it to AnimatorStepsRange to match the file/definition then
Contributor
|
🇪🇸 |
viddo
added a commit
that referenced
this pull request
Nov 25, 2015
Implement allow custom animator range
rochoa
added a commit
that referenced
this pull request
Nov 25, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #242
The steps range have been implicitly
[0, steps], to allow setting a custom range I had to make the start+end values explicit. I added astepsRangeconcept that holds these values, there's adefaultStepsRangethat works as a fallback in case acustomStepsRangeis not set.I tried my best to follow existing style and code conventions.
@rochoa can you code review?
cc @javisantana