github workflows: Enhance Python workflow to include linting#4
Merged
nathanchance merged 3 commits intoDec 7, 2022
Merged
Conversation
flake8 and pylint have several useful warnings that can help catch problems before they occur at run time. Integrate them into the current yapf.yml and rename to python_lint.yml. The disabled pylint warnings are completely opinionated based on my own personal Python code, as I have been running this for a couple weeks on my own but I figured it was worth integrating here to use for CBL Python code. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
msfjarvis and
nickdesaulniers
as code owners
This was referenced Dec 3, 2022
compnerd
approved these changes
Dec 3, 2022
compnerd
left a comment
compnerd
left a comment
Member
There was a problem hiding this comment.
LGTM (needed for ClangBuiltLinux/containers#48)
build-llvm.py triggers this. It might be possible to split the script up into smaller modules and reduce the number of directories in the Directories class but that can be done at a later time. Turn them off for now. Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
force-pushed
the
add-python-linting
branch
from
7a35eb0 to
bbe35c2
Compare
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
msfjarvis
approved these changes
Dec 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8andpylinthave several useful warnings that can help catchproblems before they occur at run time. Integrate them into the current
yapf.ymland rename topython_lint.yml.The disabled pylint warnings are completely opinionated based on my own
personal Python code, as I have been running this for a couple weeks on
my own but I figured it was worth integrating here to use for CBL Python
code.
This will require updates to all repositories that rely on
yapf.yml,which I will be handling shortly.