containers: Fixes for flake8 and pylint#48
Merged
Conversation
ci/install-vm.py:13:21: E251 unexpected spaces around keyword / parameter equals Signed-off-by: Nathan Chancellor <nathan@kernel.org>
As recommended by pylint: ci/install-vm.py:44:16: C0209: Formatting a regular string which could be a f-string (consider-using-f-string) ci/install-vm.py:65:27: C0209: Formatting a regular string which could be a f-string (consider-using-f-string) ci/install-vm.py:72:31: C0209: Formatting a regular string which could be a f-string (consider-using-f-string) ci/install-vm.py:77:8: C0209: Formatting a regular string which could be a f-string (consider-using-f-string) Signed-off-by: Nathan Chancellor <nathan@kernel.org>
This is a script, not a module. ci/install-vm.py:1:0: C0103: Module name "install-vm" doesn't conform to snake_case naming style (invalid-name) Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
requested review from
compnerd and
nickdesaulniers
as code owners
compnerd
approved these changes
Dec 3, 2022
compnerd
left a comment
compnerd
left a comment
Member
There was a problem hiding this comment.
This seems like a good idea - python evolution likely will help.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
force-pushed
the
linting-fixes
branch
from
aba0a59 to
9a511dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual commits for the warnings.
Depends on ClangBuiltLinux/actions-workflows#4.