boot-qemu.py: Workaround PLW1509 warning from Ruff#112
Merged
Conversation
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
tpimh
as code owners
msfjarvis
approved these changes
Aug 18, 2023
This is the same warning from pylint that was disabled in ClangBuiltLinux/actions-workflows#5. boot-qemu.py:216:35: PLW1509 `preexec_fn` argument is unsafe when using threads 'preexec_fn' is on the path towards deprecation, so workaround this warning by refactoring the code to use the new keyword argument 'process_group' when using Python 3.11 and newer, which makes it clear that we don't need 'preexec_fn' longterm. This conveniently hides the 'preexec_fn' use in Popen() so there is no more warning. Link: https://beta.ruff.rs/docs/rules/subprocess-popen-preexec-fn/ Signed-off-by: Nathan Chancellor <nathan@kernel.org>
nathanchance
force-pushed
the
avoid-ruff-plw1509
branch
from
079e38a to
4bc7264
Compare
msfjarvis
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same warning from
pylintthat was disabled in ClangBuiltLinux/actions-workflows#5.preexec_fnis on the path towards deprecation, so workaround this warning by refactoring the code to use the new keyword argumentprocess_groupwhen using Python 3.11 and newer, which makes it clear that we don't needpreexec_fnlongterm. This conveniently hides thepreexec_fnuse inPopen()so there is no more warning.Link: https://beta.ruff.rs/docs/rules/subprocess-popen-preexec-fn/