Skip to content

boot-qemu.py: Workaround PLW1509 warning from Ruff #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msfjarvis merged 1 commit into from
Aug 18, 2023
Merged

boot-qemu.py: Workaround PLW1509 warning from Ruff #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions boot-qemu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,17 @@ def _run_gdb(self):
utils.die('Port 1234 is already in use, is QEMU running?')

utils.green('Starting QEMU with gdb connection on port 1234...')
with subprocess.Popen(qemu_cmd,
preexec_fn=os.setpgrp) as qemu_proc:
# setpgrp() is equivalent to setpgid(0, 0). The 'process_group'
# keyword argument is equivalent to calling setpgid(0, arg) but it
# is only available in Python 3.11 and newer.
if sys.version_info >= (3, 11, 0):
popen_kwargs = {'process_group': 0}
else:
popen_kwargs = {'preexec_fn': os.setpgrp}
# pylint seems to think process_group will be used with Python 3.10
# and earlier?
# pylint: disable-next=unexpected-keyword-arg
with subprocess.Popen(qemu_cmd, **popen_kwargs) as qemu_proc:
utils.green(f"Starting {self.gdb_bin}...")
with subprocess.Popen(gdb_cmd) as gdb_proc, \
contextlib.suppress(KeyboardInterrupt):
Expand Down