Properly fix fsync-after-INSERT issue#787
Merged
Merged
Conversation
rschu1ze
changed the title
rschu1ze
force-pushed
the
fsync-after-insert
branch
from
4012939 to
3f11303
Compare
rschu1ze
force-pushed
the
fsync-after-insert
branch
from
3f11303 to
29cc9c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #678
This PR
fsync_after_insert = 1toCREATE TABLEfor all affectedclickhouse-*,pg_clickhouseandursaconfigurations (see introduce sync calls for systems not doing fsync #704 (comment)),I didn't find other affected databases except the updated ones, therefore closing #678 as resolved.
The original issue also mentioned ClickHouse Cloud. I'm a bit reluctant to add
fsyncthere because it wouldn't be the default user experience.