Skip to content

Properly fix fsync-after-INSERT issue #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschu1ze merged 5 commits into from
Feb 10, 2026
Merged

Properly fix fsync-after-INSERT issue #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
acaba84
Revert "updating runs from external PR with automation results"
rschu1ze Feb 10, 2026
30a153e
Revert "introduce sync calls for systems not doing fsync"
rschu1ze Feb 10, 2026
29cc9c5
Properly fix fsync after INSERT issue
rschu1ze Feb 10, 2026
6ffe6a4
Update dates
rschu1ze Feb 10, 2026
74f6add
Update measurements
rschu1ze Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clickhouse-tencent/create.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,5 @@ CREATE OR REPLACE TABLE hits
CLID INTEGER NOT NULL,
PRIMARY KEY (CounterID, EventDate, UserID, EventTime, WatchID)
)
ENGINE = MergeTree;
ENGINE = MergeTree
SETTINGS fsync_after_insert = 1; -- https://github.com/ClickHouse/ClickBench/issues/678
4 changes: 2 additions & 2 deletions clickhouse-tencent/results/c6a.metal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"system": "ClickHouse (TCHouse-C)",
"date": "2025-10-09",
"date": "2026-02-10",
"machine": "c6a.metal",
"cluster_size": 1,
"proprietary": "no",
"hardware": "cpu",
"tuned": "no",
"tags": ["C++","column-oriented","ClickHouse derivative", "lukewarm-cold-run"],
"load_time": 7,
"load_time": 397,
"data_size": 15255139626,
"result": [
[0.003, 0.002, 0.002],
Expand Down
4 changes: 2 additions & 2 deletions clickhouse-tencent/results/c7a.metal-48xl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"system": "ClickHouse (TCHouse-C)",
"date": "2025-10-09",
"date": "2026-02-10",
"machine": "c7a.metal-48xl",
"cluster_size": 1,
"proprietary": "no",
"hardware": "cpu",
"tuned": "no",
"tags": ["C++","column-oriented","ClickHouse derivative", "lukewarm-cold-run"],
"load_time": 5,
"load_time": 277,
"data_size": 15251226785,
"result": [
[0.002, 0.002, 0.002],
Expand Down
18 changes: 2 additions & 16 deletions clickhouse/benchmark.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,22 +41,8 @@ seq 0 99 | xargs -P100 -I{} bash -c 'wget --continue --progress=dot:giga https:/
sudo mv hits_*.parquet /var/lib/clickhouse/user_files/
sudo chown clickhouse:clickhouse /var/lib/clickhouse/user_files/hits_*.parquet

# Do a sync before loading the data to make sure we don't penalize the system for having to sync more than it actually wrote
sync

# Measure load time including sync to disk
start=$(date +%s.%N)

clickhouse-client \
--query "INSERT INTO hits SELECT * FROM file('hits_*.parquet')" \
--max-insert-threads $(( $(nproc) / 4 ))
sync

end=$(date +%s.%N)
elapsed=$(echo "$end - $start" | bc)

echo "Load time: $elapsed s"

echo -n "Load time: "
clickhouse-client --time --query "INSERT INTO hits SELECT * FROM file('hits_*.parquet')" --max-insert-threads $(( $(nproc) / 4 ))

# Run the queries

Expand Down
3 changes: 2 additions & 1 deletion clickhouse/create-tuned.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,5 @@ CREATE OR REPLACE TABLE hits
PRIMARY KEY (CounterID, EventDate, UserID, EventTime, WatchID)
)
ENGINE = MergeTree
SETTINGS index_granularity = 1024;
SETTINGS index_granularity = 1024,
fsync_after_insert = 1; -- https://github.com/ClickHouse/ClickBench/issues/678
3 changes: 2 additions & 1 deletion clickhouse/create.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,5 @@ CREATE OR REPLACE TABLE hits
CLID INTEGER NOT NULL,
PRIMARY KEY (CounterID, EventDate, UserID, EventTime, WatchID)
)
ENGINE = MergeTree;
ENGINE = MergeTree
SETTINGS fsync_after_insert = 1; -- https://github.com/ClickHouse/ClickBench/issues/678
94 changes: 47 additions & 47 deletions clickhouse/results/c6a.metal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,58 @@
{
"system": "ClickHouse",
"date": "2026-02-03",
"date": "2026-02-10",
"machine": "c6a.metal",
"cluster_size": 1,
"proprietary": "no",
"hardware": "cpu",
"tuned": "no",
"tags": ["C++","column-oriented","ClickHouse derivative","lukewarm-cold-run"],
"load_time": 135,
"data_size": 15274182086,
"tags": ["C++","column-oriented","ClickHouse derivative", "lukewarm-cold-run"],
"load_time": 184,
"data_size": 15256709483,
"result": [
[0.004, 0.002, 0.002],
[0.022, 0.01, 0.009],
[0.044, 0.013, 0.012],
[0.114, 0.014, 0.014],
[0.726, 0.188, 0.185],
[1.246, 0.182, 0.174],
[0.015, 0.012, 0.011],
[0.02, 0.014, 0.012],
[0.83, 0.293, 0.298],
[1.123, 0.312, 0.31],
[0.405, 0.105, 0.108],
[0.708, 0.095, 0.102],
[1.324, 0.168, 0.159],
[2.054, 0.201, 0.237],
[1.341, 0.174, 0.164],
[0.53, 0.098, 0.09],
[2.244, 0.321, 0.338],
[1.803, 0.255, 0.218],
[3.771, 0.587, 0.566],
[0.093, 0.003, 0.004],
[9.513, 0.071, 0.079],
[10.828, 0.05, 0.054],
[13.947, 0.176, 0.147],
[6.73, 0.109, 0.118],
[2.328, 0.043, 0.038],
[1.002, 0.038, 0.037],
[2.491, 0.041, 0.04],
[0.51, 0.033, 0.033],
[8.397, 0.838, 0.843],
[0.067, 0.034, 0.035],
[0.236, 0.08, 0.081],
[3.618, 0.122, 0.13],
[3.634, 0.768, 0.69],
[9.453, 0.668, 0.707],
[9.455, 0.667, 0.672],
[0.093, 0.057, 0.057],
[0.098, 0.051, 0.052],
[0.043, 0.03, 0.029],
[0.061, 0.025, 0.024],
[0.157, 0.106, 0.125],
[0.031, 0.019, 0.022],
[0.032, 0.014, 0.016],
[0.024, 0.013, 0.013]
[0.005, 0.002, 0.002],
[0.085, 0.011, 0.012],
[0.037, 0.014, 0.014],
[0.114, 0.015, 0.015],
[0.308, 0.181, 0.176],
[0.836, 0.175, 0.17],
[0.015, 0.011, 0.011],
[0.017, 0.015, 0.015],
[0.411, 0.301, 0.307],
[0.731, 0.325, 0.324],
[0.203, 0.107, 0.107],
[0.172, 0.095, 0.096],
[0.947, 0.152, 0.142],
[1.667, 0.202, 0.205],
[0.868, 0.152, 0.158],
[0.165, 0.088, 0.078],
[1.988, 0.324, 0.325],
[1.327, 0.251, 0.228],
[3.242, 0.584, 0.575],
[0.066, 0.003, 0.003],
[9.462, 0.065, 0.072],
[10.948, 0.052, 0.048],
[14.053, 0.138, 0.14],
[7.194, 0.162, 0.161],
[1.982, 0.043, 0.043],
[0.987, 0.039, 0.037],
[2.511, 0.045, 0.04],
[0.537, 0.034, 0.035],
[8.458, 0.789, 0.828],
[0.055, 0.034, 0.034],
[0.216, 0.098, 0.091],
[3.671, 0.123, 0.134],
[3.742, 0.955, 0.825],
[9.56, 0.689, 0.672],
[9.598, 0.686, 0.712],
[0.122, 0.065, 0.079],
[0.09, 0.063, 0.06],
[0.048, 0.038, 0.035],
[0.057, 0.027, 0.026],
[0.173, 0.137, 0.134],
[0.038, 0.022, 0.023],
[0.032, 0.016, 0.017],
[0.025, 0.015, 0.015]
]
}

92 changes: 46 additions & 46 deletions clickhouse/results/c7a.metal-48xl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,58 @@
{
"system": "ClickHouse",
"date": "2026-02-03",
"date": "2026-02-10",
"machine": "c7a.metal-48xl",
"cluster_size": 1,
"proprietary": "no",
"hardware": "cpu",
"tuned": "no",
"tags": ["C++","column-oriented","ClickHouse derivative", "lukewarm-cold-run"],
"load_time": 180,
"data_size": 15128884085,
"load_time": 176,
"data_size": 15252391300,
"result": [
[0.003, 0.002, 0.002],
[0.027, 0.012, 0.012],
[0.041, 0.013, 0.012],
[0.112, 0.012, 0.012],
[0.456, 0.357, 0.341],
[0.722, 0.362, 0.363],
[0.014, 0.011, 0.011],
[0.022, 0.018, 0.016],
[0.415, 0.283, 0.281],
[0.547, 0.287, 0.29],
[0.223, 0.115, 0.099],
[0.195, 0.093, 0.092],
[0.748, 0.096, 0.09],
[1.727, 0.134, 0.126],
[0.956, 0.08, 0.094],
[0.302, 0.057, 0.055],
[1.878, 0.164, 0.147],
[1.534, 0.114, 0.113],
[3.199, 0.274, 0.266],
[0.061, 0.002, 0.002],
[9.278, 0.053, 0.052],
[10.851, 0.04, 0.04],
[13.731, 0.087, 0.086],
[6.847, 0.094, 0.079],
[2.382, 0.031, 0.029],
[1.018, 0.029, 0.027],
[2.488, 0.03, 0.029],
[0.578, 0.031, 0.031],
[8.28, 0.474, 0.465],
[0.074, 0.044, 0.045],
[0.188, 0.06, 0.059],
[3.655, 0.074, 0.066],
[3.6, 0.381, 0.316],
[9.284, 0.341, 0.333],
[9.306, 0.355, 0.313],
[0.091, 0.043, 0.043],
[0.039, 0.027, 0.026],
[0.032, 0.018, 0.021],
[0.031, 0.017, 0.015],
[0.066, 0.046, 0.041],
[0.023, 0.013, 0.015],
[0.021, 0.012, 0.011],
[0.02, 0.011, 0.011]
[0.002, 0.002, 0.002],
[0.137, 0.012, 0.011],
[0.083, 0.013, 0.012],
[0.157, 0.018, 0.012],
[0.878, 0.345, 0.33],
[1.113, 0.357, 0.345],
[0.017, 0.011, 0.011],
[0.021, 0.017, 0.018],
[0.764, 0.289, 0.299],
[0.871, 0.31, 0.3],
[0.389, 0.119, 0.116],
[0.69, 0.096, 0.094],
[1.301, 0.105, 0.09],
[2.079, 0.135, 0.128],
[1.417, 0.083, 0.084],
[0.587, 0.056, 0.058],
[2.186, 0.148, 0.145],
[2.011, 0.118, 0.112],
[3.606, 0.27, 0.262],
[0.123, 0.003, 0.003],
[10.047, 0.112, 0.051],
[11.375, 0.045, 0.042],
[14.439, 0.1, 0.092],
[7.726, 0.134, 0.129],
[2.696, 0.033, 0.031],
[1.267, 0.027, 0.025],
[2.753, 0.032, 0.033],
[0.784, 0.044, 0.044],
[8.672, 0.496, 0.487],
[0.086, 0.044, 0.044],
[0.454, 0.062, 0.065],
[3.959, 0.083, 0.064],
[4, 0.316, 0.316],
[9.816, 0.332, 0.305],
[9.839, 0.329, 0.321],
[0.094, 0.043, 0.042],
[0.047, 0.028, 0.027],
[0.031, 0.019, 0.02],
[0.038, 0.017, 0.016],
[0.076, 0.046, 0.045],
[0.027, 0.022, 0.015],
[0.025, 0.014, 0.012],
[0.021, 0.012, 0.012]
]
}

92 changes: 46 additions & 46 deletions clickhouse/results/c8g.metal-48xl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,58 @@
{
"system": "ClickHouse",
"date": "2026-02-03",
"date": "2026-02-10",
"machine": "c8g.metal-48xl",
"cluster_size": 1,
"proprietary": "no",
"hardware": "cpu",
"tuned": "no",
"tags": ["C++","column-oriented","ClickHouse derivative", "lukewarm-cold-run"],
"load_time": 164,
"data_size": 15268992596,
"load_time": 196,
"data_size": 15247502708,
"result": [
[0.002, 0.001, 0.001],
[0.02, 0.011, 0.01],
[0.062, 0.012, 0.01],
[0.189, 0.011, 0.011],
[0.652, 0.182, 0.304],
[1.43, 0.295, 0.286],
[0.015, 0.009, 0.009],
[0.022, 0.017, 0.017],
[0.682, 0.2, 0.2],
[1.188, 0.207, 0.211],
[0.556, 0.079, 0.08],
[0.769, 0.07, 0.061],
[1.385, 0.076, 0.078],
[2.178, 0.098, 0.098],
[1.464, 0.068, 0.065],
[0.651, 0.042, 0.041],
[2.191, 0.133, 0.132],
[2.058, 0.106, 0.104],
[3.675, 0.224, 0.22],
[0.153, 0.003, 0.003],
[10.248, 0.063, 0.063],
[11.411, 0.033, 0.032],
[14.509, 0.089, 0.093],
[7.457, 0.092, 0.092],
[2.399, 0.032, 0.032],
[1.065, 0.028, 0.029],
[2.56, 0.031, 0.03],
[0.597, 0.028, 0.027],
[8.477, 0.533, 0.528],
[0.093, 0.064, 0.064],
[0.202, 0.048, 0.047],
[3.755, 0.062, 0.058],
[3.649, 0.263, 0.258],
[9.333, 0.277, 0.275],
[9.344, 0.278, 0.276],
[0.096, 0.034, 0.033],
[0.065, 0.028, 0.026],
[0.04, 0.019, 0.02],
[0.05, 0.019, 0.017],
[0.111, 0.043, 0.041],
[0.03, 0.014, 0.014],
[0.028, 0.012, 0.013],
[0.025, 0.012, 0.012]
[0.002, 0.002, 0.001],
[0.101, 0.012, 0.011],
[0.042, 0.013, 0.012],
[0.123, 0.012, 0.012],
[0.552, 0.244, 0.278],
[0.939, 0.261, 0.263],
[0.014, 0.01, 0.01],
[0.022, 0.018, 0.018],
[0.621, 0.2, 0.199],
[0.598, 0.206, 0.211],
[0.222, 0.084, 0.081],
[0.564, 0.071, 0.072],
[1.218, 0.076, 0.076],
[1.957, 0.1, 0.1],
[1.262, 0.071, 0.072],
[0.505, 0.044, 0.046],
[2.087, 0.144, 0.141],
[1.856, 0.117, 0.113],
[3.505, 0.239, 0.236],
[0.094, 0.002, 0.002],
[9.814, 0.066, 0.065],
[11.156, 0.034, 0.033],
[14.294, 0.091, 0.094],
[7.562, 0.161, 0.161],
[2.288, 0.032, 0.031],
[1.195, 0.027, 0.027],
[2.673, 0.032, 0.032],
[0.702, 0.029, 0.029],
[8.523, 0.449, 0.448],
[0.093, 0.063, 0.063],
[0.219, 0.046, 0.048],
[3.832, 0.06, 0.061],
[3.799, 0.262, 0.262],
[9.579, 0.287, 0.28],
[9.501, 0.302, 0.287],
[0.14, 0.034, 0.035],
[0.078, 0.051, 0.049],
[0.048, 0.03, 0.029],
[0.054, 0.024, 0.023],
[0.123, 0.086, 0.091],
[0.042, 0.017, 0.019],
[0.029, 0.015, 0.015],
[0.025, 0.012, 0.013]
]
}

Loading