Migrate IBAN validation to iban-commons#1161
Open
spannm wants to merge 1 commit into
Open
Conversation
- replace iban4j dependency with iban-commons v1.8.6 - update IBANValidatorForString to use de.speedbanking.iban.Iban - simplify isValid logic using short-circuit evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
iban-commonsin favor ofiban4j.iban-commonshas demonstrated to be superior in terms of performance, allocation (GC pressure), country coverage etc.The internal validation logic in
IBANValidatorForStringhas been refactored for better performance and readability.I am an author of the
iban-commonslibrary (GitHub).