Skip to content

Migrate IBAN validation to iban-commons #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spannm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate IBAN validation to iban-commons #1161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions common-dto/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@
<version>2.0.1.Final</version>
<optional>true</optional>
</dependency>
<!-- iban-commons: Zero-dependency, high-performance Java 8+ IBAN and BIC validation library -->
<dependency>
<groupId>org.iban4j</groupId>
<artifactId>iban4j</artifactId>
<version>3.2.13-RELEASE</version>
<groupId>de.speedbanking</groupId>
<artifactId>iban-commons</artifactId>
<version>1.8.6</version>
<optional>true</optional>
</dependency>
<dependency>
Expand Down
17 changes: 2 additions & 15 deletions ...o/src/main/java/com/liberologico/cloudesire/common/validators/IBANValidatorForString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.liberologico.cloudesire.common.validators;

import org.iban4j.IbanUtil;
import de.speedbanking.iban.Iban;

import javax.validation.ConstraintValidator;
import javax.validation.ConstraintValidatorContext;
Expand All @@ -16,19 +16,6 @@ public void initialize( IBAN constraintAnnotation )
@Override
public boolean isValid( String iban, ConstraintValidatorContext context )
{
if ( iban == null )
{
return true;

}
try
{
IbanUtil.validate( iban );
}
catch ( Exception e )
{
return false;
}
return true;
return iban == null || Iban.isValid(iban);
}
}