Fix #4497: Make worker and statsd optional in development setup#4498
Fix #4497: Make worker and statsd optional in development setup#4498RishabhJain2018 merged 3 commits intoCloud-CV:masterfrom
Conversation
- Updated to use profiles for and - Updated to document how to start optional containers using profiles
RishabhJain2018
left a comment
There was a problem hiding this comment.
@ilyasd3 Please add a video showing all three commands are working as expected :)
|
@RishabhJain2018 I need to make some changes to other files to get the commands to work as expected. For example, I encountered an Exit Code 100 error from |
|
I wonder why you need to do it? The current |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4498 +/- ##
==========================================
- Coverage 72.93% 69.30% -3.63%
==========================================
Files 83 20 -63
Lines 5368 3574 -1794
==========================================
- Hits 3915 2477 -1438
+ Misses 1453 1097 -356 see 64 files with indirect coverage changes see 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This is a video of the error I am encountering. I am on macOS Sequoia 15.3.2. |
|
@RishabhJain2018 this macos issue is persistent. I faced it too. Can you raise issue for this? |
|
Hey @lazyperson1020 , Thanks for confirming this. Can one of you guys work to fix this? |
|
@ilyasd3 let's work together? Actually I was able to build the project on mac after bypassing some of the things. |
Sounds good! Keep me updated with your progress and let me know what I can do. |
|
Hey @ilyasd3 @lazyperson1020 regarding the error you guys are encountering... It basically instructs Docker to pull from a compatible architecture rather than defaulting to one that suits the host machine. I've built EvalAI on my system using Mac-OS |
Yeah, I had done that actually. I was just wondering if that is something we should create a pull request for as well? Maybe @RishabhJain2018 can advise. |
|
@Zahed-Riyaz |
|
@lazyperson1020 so far for me it hasn't really impacted reproducing any issues or running EvalAI, I haven't really looked into it but it's been working fine ignoring the warning |
|
Ah..I see..you guys are using M1/M2 chips Mac. |
|
@Zahed-Riyaz I encountered some issues like |
|
Can you guys try this Dockerfile for the |
|
So, it would be nice if --
Please let me know if it works and also add where did you try building it. |
|
I just tried it on my M3 MacBook which is still based on the ARM64 architecture as the M1 and M2 chips, and it worked for me. |
|
If it works on all three, please raise a new PR with the Dockerfile change only for nodejs :) |
|
@RishabhJain2018 works fine on my mac m1 now. |
|
It works! I faced issues with installing worker.txt libraries but it goes smoothly when I make worker optional as suggested in #4497. |
|
@RishabhJain2018 Is there any other PR I can raise for anything else? |
|
Hey @Zahed-Riyaz , Which OS did you try it on? |
@ilyasd3 Please pick from the issues list while we are iterating on this PR. |
|
@RishabhJain2018 I ran it on M1 chip |
|
Can you guys try it on linux and apple intel mac too before we merge this PR to check compatibility of the Dockerfile. |
|
I just tested it on Apple Intel MacBook and it worked. To test on Linux, can I do that in a cloud environment like AWS? |
Yes, please do! |
|
I just tested it on an AWS Ubuntu Server 22.04 LTS (64-bit x86) EC2 instance and it worked. |
|
Awesome, thanks! |
|
Thanks for checking that. Now, we need a new PR with the updated Dockerfile of nodejs (only in dev mode), and then we can merge this PR after that. If you can do that then I'll ask @Zahed-Riyaz to not open that PR. |
|
@RishabhJain2018 I'm really happy to have my PR merged and would love to contribute further to CloudCV as part of GSoC 2025. I think CloudCV’s mission of making AI research more reproducible and accessible is incredibly inspiring, and I’d love to support the project in any way I can. My background in AWS and Python aligns well with the skills required, and I’d really appreciate any guidance on how to get more involved! |
|
Hey @ilyasd3 , Please pick any other issue to work on! |
* Make worker and statsd optional in development setup - Updated to use profiles for and - Updated to document how to start optional containers using profiles * update Dockerfile of nodejs in dev mode --------- Co-authored-by: Rishabh Jain <rishabhjain2018@gmail.com>
Summary
docker-compose.ymlto use profiles forworkerandstatsd-exporterREADME.mdto document how to start optional containers using profilesChanges Introduced
workerandstatsd-exportercontainers are now optional in development.Testing
docker-compose uponly starts required services.workerstarts correctly with--profile worker.statsd-exporterstarts correctly with--profile statsd.Bug Number
Fixes #4497