[FLOC-4506] Remove the obsolete container API tests #2914
[FLOC-4506] Remove the obsolete container API tests #2914
Conversation
…locker-diagnostics tests and various ancillary code.
wallnerryan
left a comment
wallnerryan
left a comment
There was a problem hiding this comment.
preliminary review, i know your still working on this one.
| @@ -876,18 +747,6 @@ def cleanup_all_containers(_): | |||
| for container in client.containers(): | |||
| client.remove_container(container["Id"], force=True) | |||
There was a problem hiding this comment.
is this calling the container API or docker?
There was a problem hiding this comment.
That one calls the Docker API to remove all containers.
| d = DeferredContext(cleanup_leases()) | ||
| d.addCallback(cleanup_flocker_containers) | ||
| if remove_foreign_containers: | ||
| d.addCallback(cleanup_all_containers) |
There was a problem hiding this comment.
same, does this call docker or the container api?
There was a problem hiding this comment.
Yep, same thing. It calls the Docker API.
| return d | ||
|
|
||
|
|
||
| def is_process_running(node, name): |
There was a problem hiding this comment.
this doesnt seem specific to container-agent removal, intended to be removed?
There was a problem hiding this comment.
That function is no longer used inside Flocker so I decided to remove it.
Same for a bunch of other functions.
It seemed better than leaving them lying around and future maintainers having to think about why the function exists.
…tainer-acceptance-tests-FLOC-4506
…tainer-acceptance-tests-FLOC-4506
…-obsolete-container-acceptance-tests-FLOC-4506
…-obsolete-container-acceptance-tests-FLOC-4506
|
I replaced this with #2917 so that I can merge into a remove container API feature branch. |
wallrj
deleted the
remove-obsolete-container-acceptance-tests-FLOC-4506
branch
2 participants
Fixes: https://clusterhq.atlassian.net/browse/FLOC-4506
Also removed container agent related flocker-diagnostics tests and various ancillary code which appears not to be used elsewhere.