[FLOC-4506] Remove the obsolete container API tests#2917
Merged
wallrj merged 14 commits intoremove-container-api-FLOC-4505from Oct 4, 2016
Merged
Conversation
…locker-diagnostics tests and various ancillary code.
…tainer-acceptance-tests-FLOC-4506
…tainer-acceptance-tests-FLOC-4506
…-obsolete-container-acceptance-tests-FLOC-4506
…-obsolete-container-acceptance-tests-FLOC-4506
This was referenced Oct 4, 2016
wallnerryan
approved these changes
Oct 4, 2016
Contributor
wallnerryan
left a comment
wallnerryan
left a comment
There was a problem hiding this comment.
one question and 1 nit but overall looks good and tests are passing. wish I had more time spent on this review though, but merge when you are happy.
| DOCKER_CLIENT_LOCK = DeferredLock() | ||
|
|
||
|
|
||
| def deferToThreadWithLock(lock, f, *args, **kwargs): |
| :param Cluster cluster: The ``Cluster`` with certificates for | ||
| authenticating with the docker daemon on ``node``. | ||
| :param unicode image_name: A name of the Docker image to use. | ||
| :param Dataset dataset: The mounted Flocker dataset to bind mount into the |
Contributor
There was a problem hiding this comment.
How do we cleanup this dataset? I think im missing where that happens.
Contributor
Author
There was a problem hiding this comment.
The create_dataset(test=self, ...) function registers a TestCase.addCleanup function to remove the dataset using a Flocker API call.
Contributor
Author
|
Thanks for the review @wallnerryan. |
wallrj
deleted the
remove-obsolete-container-acceptance-tests-FLOC-4506
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://clusterhq.atlassian.net/browse/FLOC-4506
Also removed container agent related flocker-diagnostics tests and various ancillary code which appears not to be used elsewhere.
This is the same as #2914 but merging into the remove-container-api-FLOC-4505 feature branch instead of into master.