Notifications#27
Conversation
ghost
assigned
RignonNoel
left a comment
RignonNoel
left a comment
There was a problem hiding this comment.
After full review it seems you want to include the possibility to put a notification as Unread. I really not against this choice but i don't understant the value, for me it's seems just strange.
Otherwise all the rest seems good to me, just check this little artefact to be sure your good with that.
Good work 👍
| constructor(public storage: Storage, protected http:Http, private _config:Config) { | ||
| this.serverURL = _config.get('apiUrl'); | ||
| storage.get('user_id').then( | ||
| (user_id) => { |
There was a problem hiding this comment.
I think it's an artefact of your first urls architecture on the API because you don't need the user_id in this line.
|
@RignonNoel I removed the unused check! |
RignonNoel
left a comment
RignonNoel
left a comment
There was a problem hiding this comment.
Yeah, it's not a bad idea. ;)
2 participants
What have you changed ?
The project page with the new notification button
How did you do that ?
A new NotificationService was added to communicate with the new /notification endpoint of the server;
A new page was also added and is used to display read and unread notification that you are the recipient.
Important, it cannot work without the back-end: ColabTask/api-tasklist#17