Skip to content

Add ROCm 7.2 support and default to it#476

Merged
bigcat88 merged 1 commit into
Comfy-Org:mainfrom
chejh-amd:feat/rocm-7.2
Jul 5, 2026
Merged

Add ROCm 7.2 support and default to it#476
bigcat88 merged 1 commit into
Comfy-Org:mainfrom
chejh-amd:feat/rocm-7.2

Conversation

@chejh-amd

Copy link
Copy Markdown
Contributor

Closes #472.

comfy install --gpu amd currently defaults to ROCm 6.3, and the ROCmVersion enum stops at 7.1, so there's no way to pull the current ROCm 7.2 PyTorch wheels. PyTorch now ships ROCm 7.2 wheels at https://download.pytorch.org/whl/rocm7.2, so this adds 7.2 to the enum and makes it the default. Follows the same shape as #379 (which added the flag and bumped the default 6.1 → 6.3), including the test updates.

Changes

  • constants.py: add v7_2 = "7.2" to ROCmVersion.
  • cmdline.py / command/install.py: bump default rocm_version v6_3v7_2.
  • uv.py: bump rocmPytorchUrl and rocmTorchBackend rocm6.3rocm7.2.
  • tests/uv/test_uv.py: test_torch_backend_amd now expects the rocm7.2 default backend.
  • tests/comfy_cli/test_install_python_resolution.py: add the 7.2 → whl/rocm7.2 case to the parametrized URL test.

Users can still pin an older build with --rocm-version 7.1 (or 6.x).

Why bumping the default is safe for older cards

The ROCm 7.2 wheel is built for a wide arch list, so RDNA2/older cards stay covered, not just RDNA3/4: gfx900, gfx906, gfx908, gfx90a, gfx942, gfx950, gfx1030, gfx1100, gfx1101, gfx1102, gfx1150, gfx1151, gfx1200, gfx1201

Tested

Verified torch 2.12.1+rocm7.2 installs and initializes from the rocm7.2 index on two AMD systems:

GPU Arch ROCm torch cuda.is_available()
AMD Radeon AI PRO R9700 gfx1201 (RDNA4) 7.2.0 2.12.1+rocm7.2 True
Radeon 8060S / Ryzen AI Max+ 395 (Strix Halo) gfx1151 (RDNA3.5) 7.2.1 2.12.1+rocm7.2 True

Unit tests pass locally: pytest tests/uv/test_uv.py tests/comfy_cli/test_install_python_resolution.py → 61 passed.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8c8cf9c5-fa9d-4f16-b396-1ddb4444b685

📥 Commits

Reviewing files that changed from the base of the PR and between 7e87c77 and 38fb9fd.

📒 Files selected for processing (6)
  • comfy_cli/cmdline.py
  • comfy_cli/command/install.py
  • comfy_cli/constants.py
  • comfy_cli/uv.py
  • tests/comfy_cli/test_install_python_resolution.py
  • tests/uv/test_uv.py

📝 Walkthrough

Walkthrough

The default ROCm version used across comfy-cli was bumped from 6.3 to 7.2. A new ROCmVersion.v7_2 enum member was added, and default parameters plus wheel URLs/backend tags in the CLI, installer, and DependencyCompiler were updated accordingly, with tests adjusted to match.

Changes

ROCm 7.2 default update

Layer / File(s) Summary
ROCmVersion enum and torch URL
comfy_cli/constants.py, comfy_cli/uv.py
Adds ROCmVersion.v7_2 = "7.2" and updates DependencyCompiler.rocmPytorchUrl/rocmTorchBackend from rocm6.3 to rocm7.2.
Default rocm_version wiring
comfy_cli/cmdline.py, comfy_cli/command/install.py
Changes default rocm_version from v6_3 to v7_2 for the install CLI option, pip_install_comfyui_dependencies, and execute.
Test expectations for rocm7.2
tests/comfy_cli/test_install_python_resolution.py, tests/uv/test_uv.py
Adds a v7_2 parametrized test case and updates the AMD torch backend assertion to "rocm7.2".

No sequence diagram needed here — just a version number getting its glow-up, from 6.3 to a snazzier 7.2! 🎉

Related Issues: Resolves ROCm outdated version concern (#472) — comfy-cli was fetching ROCm 6.3 by default while 7.2.4 was already out and about.

Suggested Labels: enhancement, dependencies

Suggested Reviewers: (based on ownership of comfy_cli/uv.py and comfy_cli/command/install.py)

Poem
A rabbit hopped through ROCm's code,
Found 6.3 an outdated road,
With a twitch of nose and a cheerful grin,
Bumped it to 7.2 and let the new torch spin! 🐇⚡

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR updates AMD installs to ROCm 7.2 defaults and URLs, matching the issue’s request to replace outdated ROCm 6.3 support.
Out of Scope Changes check ✅ Passed The added enum, default updates, and test adjustments are all directly related to ROCm 7.2 support; no unrelated changes are evident.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chejh-amd

Copy link
Copy Markdown
Contributor Author

I have read and agree to the Contributor License Agreement

comfy-legal added a commit to Comfy-Org/comfy-cla that referenced this pull request Jul 1, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2026
@bigcat88 bigcat88 merged commit c2cac0f into Comfy-Org:main Jul 5, 2026
13 of 14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated ROCm version?

2 participants