Skip to content

Add ROCm 7.2 support and default to it #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigcat88 merged 1 commit into from
Jul 5, 2026
Merged

Add ROCm 7.2 support and default to it #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion comfy_cli/cmdline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ def install(
),
] = None,
cuda_version: Annotated[CUDAVersion | None, typer.Option(show_default=False)] = None,
rocm_version: Annotated[ROCmVersion, typer.Option(show_default=True)] = ROCmVersion.v6_3,
rocm_version: Annotated[ROCmVersion, typer.Option(show_default=True)] = ROCmVersion.v7_2,
amd: Annotated[
bool | None,
typer.Option(
Expand Down
4 changes: 2 additions & 2 deletions comfy_cli/command/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def pip_install_comfyui_dependencies(
skip_torch_or_directml: bool,
skip_requirement: bool,
python: str = sys.executable,
rocm_version: constants.ROCmVersion = constants.ROCmVersion.v6_3,
rocm_version: constants.ROCmVersion = constants.ROCmVersion.v7_2,
cuda_tag: str | None = None,
):
os.chdir(repo_dir)
Expand Down Expand Up @@ -153,7 +153,7 @@ def execute(
gpu: constants.GPU_OPTION | None = None,
cuda_version: constants.CUDAVersion | None = None,
cuda_tag: str | None = None,
rocm_version: constants.ROCmVersion = constants.ROCmVersion.v6_3,
rocm_version: constants.ROCmVersion = constants.ROCmVersion.v7_2,
plat: constants.OS = None,
skip_torch_or_directml: bool = False,
skip_requirement: bool = False,
Expand Down
1 change: 1 addition & 0 deletions comfy_cli/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ class CUDAVersion(str, Enum):


class ROCmVersion(str, Enum):
v7_2 = "7.2"
v7_1 = "7.1"
v7_0 = "7.0"
v6_3 = "6.3"
Expand Down
4 changes: 2 additions & 2 deletions comfy_cli/uv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,11 @@ def parse_req_file(rf: PathLike, skips: list[str] | None = None):

class DependencyCompiler:
cpuPytorchUrl = "https://download.pytorch.org/whl/cpu"
rocmPytorchUrl = "https://download.pytorch.org/whl/rocm6.3"
rocmPytorchUrl = "https://download.pytorch.org/whl/rocm7.2"
nvidiaPytorchUrl = "https://download.pytorch.org/whl/cu126"

cpuTorchBackend = "cpu"
rocmTorchBackend = "rocm6.3"
rocmTorchBackend = "rocm7.2"
nvidiaTorchBackend = "cu126"

overrideGpu = dedent(
Expand Down
1 change: 1 addition & 0 deletions tests/comfy_cli/test_install_python_resolution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ class TestTorchInstallCommands:
@pytest.mark.parametrize(
"rocm_version,expected_url",
[
(constants.ROCmVersion.v7_2, "https://download.pytorch.org/whl/rocm7.2"),
(constants.ROCmVersion.v7_1, "https://download.pytorch.org/whl/rocm7.1"),
(constants.ROCmVersion.v7_0, "https://download.pytorch.org/whl/rocm7.0"),
(constants.ROCmVersion.v6_3, "https://download.pytorch.org/whl/rocm6.3"),
Expand Down
2 changes: 1 addition & 1 deletion tests/uv/test_uv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def test_torch_backend_nvidia():

def test_torch_backend_amd():
depComp = DependencyCompiler(cwd=temp, gpu=GPU_OPTION.AMD, outDir=temp, reqFilesCore=[], reqFilesExt=[])
assert depComp.torchBackend == "rocm6.3"
assert depComp.torchBackend == "rocm7.2"
assert depComp.gpuUrl == DependencyCompiler.rocmPytorchUrl


Expand Down
Loading