Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

refactor: migrate deprecated IConfig app-values to IAppConfig#293

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/iappconfig-migration
May 26, 2026
Merged

refactor: migrate deprecated IConfig app-values to IAppConfig#293
rubenvdlinde merged 1 commit into
developmentfrom
chore/iappconfig-migration

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Summary

  • Migrates IConfig::getAppValue in HealthController to the modern OCP\IAppConfig::getValueString typed accessor (NC26+ API)
  • Adds IAppConfig constructor injection alongside the retained IConfig (still required for getSystemValueString)
  • Behavior-preserving: same key, same default, same return type — no logic changes

Details

  • File: lib/Controller/HealthController.php
  • Call migrated: $this->config->getAppValue(appName: APP_ID, key: 'installed_version', default: '0.0.0')$this->appConfig->getValueString(...)
  • User-values (getUserValue/setUserValue/deleteUserValue in PreferencesController): left on IConfig — NC min-version is 28, OCP\IUserConfig requires NC≥31

Test plan

  • php -l lib/Controller/HealthController.php — no syntax errors
  • Gate-16 spec coverage: exit 0
  • Health endpoint /api/health returns correct version string

@rubenvdlinde rubenvdlinde merged commit cbb6451 into development May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant