Skip to content
This repository was archived by the owner on May 29, 2026. It is now read-only.

refactor: migrate deprecated IConfig app-values to IAppConfig #293

Merged
rubenvdlinde merged 1 commit into from
May 26, 2026
Merged

refactor: migrate deprecated IConfig app-values to IAppConfig #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Controller/HealthController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
use OCP\AppFramework\Http\Attribute\NoCSRFRequired;
use OCP\AppFramework\Http\Attribute\PublicPage;
use OCP\AppFramework\Http\JSONResponse;
use OCP\IAppConfig;
use OCP\IConfig;
use OCP\IRequest;
use Psr\Container\ContainerInterface;
Expand All @@ -54,13 +55,15 @@ class HealthController extends Controller
*
* @param IRequest $request The request object
* @param IConfig $config The Nextcloud config service
* @param IAppConfig $appConfig The typed app-config service
* @param ContainerInterface $container The DI container (for lazy OR lookup)
*
* @return void
*/
public function __construct(
IRequest $request,
private readonly IConfig $config,
private readonly IAppConfig $appConfig,
private readonly ContainerInterface $container,
) {
parent::__construct(appName: Application::APP_ID, request: $request);
Expand All @@ -83,7 +86,7 @@ public function __construct(
public function status(): JSONResponse
{
$baseUrl = $this->config->getSystemValueString(key: 'overwrite.cli.url', default: '');
$version = $this->config->getAppValue(appName: Application::APP_ID, key: 'installed_version', default: '0.0.0');
$version = $this->appConfig->getValueString(app: Application::APP_ID, key: 'installed_version', default: '0.0.0');
$orStatus = 'unavailable';

try {
Expand Down