This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(docs): adopt @conduction/docusaurus-preset#137
Merged
Conversation
Replace the inline @docusaurus/preset-classic configuration with a createConfig() call from @conduction/docusaurus-preset@^1.2.1. The preset wraps the classic preset, registers the brand theme plugin (navbar / footer swizzles + auto-loaded brand.css), and pre-applies the cobalt + KNVB orange + Plex Mono brand defaults. Mydash-specific overrides keep their previous behaviour: - i18n: en-only (Dutch is still parked pending translation pass; the preset's nl/en/de/fr block is replaced wholesale) - presets: docs.path: './' for the docs-at-root layout, blog disabled, customCss for the mydash-specific overrides - themes: re-includes the brand theme plugin alongside theme-mermaid (createConfig replaces themes wholesale when an opt is passed) - navbar: docSidebar entry + GitHub link + locale dropdown - footer (preset 1.2.0+): per-property override — passes only `links`, filtered to the brand "Conduction" column. The brand `style: 'dark'` and the brand KvK/BTW/IBAN copyright string both inherit unchanged - prism + mermaid theme config carry through themeConfig (shallow- merged into the preset's defaults) - markdown.mermaid + markdown.hooks.onBrokenMarkdownImages + onBrokenAnchors + trailingSlash assigned post-createConfig because createConfig doesn't pass-through arbitrary top-level fields Net effect: mydash.conduction.nl picks up the Conduction brand chrome (cobalt navbar, dark footer panel with the KvK/BTW anchor, Plex Mono captions) the next time the docs build deploys. Site-specific Product and Support footer columns are intentionally not added — those will slot in beside the brand "Conduction" column in a follow-up once we decide which links go where.
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 501/501 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 90.7% (127/140 statements)
Quality workflow — 2026-05-07 08:40 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Net effect
Once this merges and the documentation workflow deploys, mydash.conduction.nl picks up the Conduction brand chrome — cobalt navbar, dark footer panel with KvK/BTW anchor, Plex Mono captions, the brand colour palette mapped onto Docusaurus's Infima theme variables.
Mydash-specific Product / Support / etc. footer columns are intentionally not added in this PR — those will slot in next to the brand "Conduction" column in a follow-up once the link list is decided. The preset infrastructure is in place to accept them.
Why bumped to 1.2.1
While wiring this in, the build surfaced a packaging bug in the preset:
`src/css/tokens.css` imports the design-system monorepo's canonical
`tokens.css` and `typography.css` via three-up relative paths, which
only resolve inside the monorepo. Consumers installing via npm hit
`Can't resolve '../../../tokens.css'`. Fixed in design-system at
c8e3de7 by adding a `prepack` lifecycle script that bundles the canonical content into the preset before `npm publish`. The fix is live as `@conduction/docusaurus-preset@1.2.1`.
Test plan
Verified locally