This repository was archived by the owner on May 29, 2026. It is now read-only.
feat: brand landing + dual-brand footer + in-app docs link#138
Merged
Conversation
Two coupled changes shipping together because they share the @conduction/docusaurus-preset@^1.4.1 dependency bump: DOCS SITE (mydash.conduction.nl) - Replace docs/src/pages/index.js's Docusaurus-classic homepage with a brand <DetailHero> + <WidgetShelf> composition mirroring the connext apps/mydash.mdx page. Authored as .js (not .mdx) because the docs plugin's `path: './'` collides with mdx-loader on the pages/index.mdx route — the JSX path renders identically and bypasses the MDX-ESM parser quirk. - Hero opts in to the orange-accent identity: iconColor + primaryCta.tone use the new tone="orange" Button variant from preset 1.3.0+. App-store install link as primary, docs intro as secondary, GitHub repo as tertiary. AppMock illustration on the right. - WidgetShelf renders the three product cards (BI on a register, Calendar, Werkvoorraad) with the same inline panels the connext page uses. - Drop the trailingSlash:false override so /docs/intro/ resolves cleanly under GH Pages (the prior config 404'd /-suffix URLs). - minigames:false on the canal-footer drops the boat-sinking + kade-cyclist mini-games while keeping the static skyline + canal decoration. Kade-cyclist.js is also no longer fetched. - footerBrand renders Conduction + Sendent logos side by side in the brand block; Sendent column added to footer.links beside the brand "Conduction" anchor. Logos copied from the parent app's img/ into docs/static/img/partners/. - docs.path uses an explicit `exclude: ['src/**']` so the docs plugin and pages plugin don't both scan src/pages and double- process the landing. - HomepageFeatures component + index.module.css removed; both obsolete now that the landing is preset-driven. NEXTCLOUD APP (in-app Documentation link) - DOCS_URL in SidebarFooter.vue and doc-url in AdminSettings.vue now point at https://mydash.conduction.nl/docs/intro instead of the marketing landing. Click context is a user inside the app reaching for docs, not a prospect evaluating the product.
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 501/501 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 90.7% (127/140 statements)
Quality workflow — 2026-05-07 19:27 UTC
Download the full PDF report from the workflow artifacts.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two coupled changes shipping together because both depend on `@conduction/docusaurus-preset@^1.4.1`:
Docs site (mydash.conduction.nl)
Nextcloud app (in-app Documentation link)
Verified locally
Test plan
Branch policy
Filed as `feature/landing-page-and-app-link` (the previous `chore/adopt-conduction-preset` PR #137 was admin-merged through the branch-policy check; this one satisfies it organically).