This repository was archived by the owner on May 29, 2026. It is now read-only.
chore: regenerate package-lock.json to fix quality CI failures#29
Merged
Conversation
… deps PR #28 (merge 4601d2c) shipped a package-lock.json that was missing 11 transitive dependencies of pinia (devtools-kit, devtools-shared, mitt, perfect-debounce, speakingurl, superjson, copy-anything, is-what, rfdc, plus a nested @nextcloud/dialogs > pinia entry). Result: `npm ci` failed on every CI quality job, taking down 5 checks at once (Security npm, License npm, ESLint, Stylelint, SBOM). Fix: regenerate the lockfile with `npm install` (no package.json changes). Verified locally: - `npm ci` now succeeds - `npm run lint` passes - `npm run stylelint` passes - `npm audit --audit-level=high` reports 0 high/critical (25 low/moderate)
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 427/427 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-11 11:19 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #28 (merge commit 4601d2c) shipped a
package-lock.jsonthat was missing 11 transitive dependencies ofpinia(the devtools chain, plus a nested @nextcloud/dialogs > pinia entry). As a result,npm cifailed on every quality job in CI run 25665979136, taking down 5 checks at once:All 5 failed at the same step (
npm ci), with the same error:Missing: pinia@3.0.4 from lock fileplus a list of pinia's transitive deps.Fix
Regenerated
package-lock.jsonvianpm installagainst the existingpackage.json(no package.json changes). The 131-line diff adds the missing transitive entries (@vue/devtools-kit,@vue/devtools-shared,copy-anything,is-what,mitt,perfect-debounce,rfdc,speakingurl,superjson, plus a nested pinia under @nextcloud/dialogs).Test plan
npm cisucceeds locally with the new lockfilenpm run lint(eslint) passesnpm run stylelintpassesnpm audit --audit-level=highreports 0 high/critical findings (25 low/moderate remain, not blocking)