This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: add sass + sass-loader to devDeps + use placeholders for info.xml marketing copy#28
Merged
rubenvdlinde merged 1 commit intoMay 11, 2026
Conversation
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-11 10:00 UTC
Download the full PDF report from the workflow artifacts.
4 tasks
…copy with placeholders The SCSS webpack rule was added to webpack.config.js in a prior PR (commit 209224e "chore: bump nextcloud-vue + router, add axios alias"), but the actual sass + sass-loader packages were never added to devDependencies. Result: running 'npm run build' on a fresh clone of the development branch produces a 'Module parse failed: Unexpected token' error whenever nextcloud-vue components ship <style lang=scss> blocks. Fix: - package.json devDependencies: add sass ^1.99.0, sass-loader ^16.0.8 (matching the versions already in opencatalogi + decidesk) - package-lock.json regenerated via 'npm install --package-lock-only' Separately, appinfo/info.xml currently ships marketing copy for the template itself (Nextcloud App Template, A template for creating new Nextcloud apps, plus a 13-line feature-list description). This copy survives '/app-create' scaffolding because the placeholder substitution phase only rewrites identifier-shaped tokens (app-template -> {APP_ID}, AppTemplate -> {APP_NAMESPACE}). Result: every newly scaffolded app ships with the template's own description until a human remembers to rewrite it. Fix: - appinfo/info.xml: replace summary + description content with {APP_NAME}, {APP_SUMMARY}, {APP_DESCRIPTION} placeholders so the /app-create skill can auto-substitute them from openspec/app-config.json during scaffolding. Companion PR in ConductionNL/market-intelligence updates the .claude/skills/app-create placeholder-replacement-guide.md so the new placeholders get processed automatically.
rubenvdlinde
force-pushed
the
fix/scss-support-and-cleaner-placeholders
branch
from
ea28593 to
034301e
Compare
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-11 10:57 UTC
Download the full PDF report from the workflow artifacts.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sass ^1.99.0+sass-loader ^16.0.8to devDependencies (matching the versions opencatalogi + decidesk already pin). The SCSS webpack rule was added in commit 209224e but the actual loader packages were never installed — fresh clones failnpm run buildwhenever an aliased@conduction/nextcloud-vuecomponent ships<style lang="scss">.{APP_NAME},{APP_SUMMARY},{APP_DESCRIPTION}placeholders so/app-createcan auto-substitute fromopenspec/app-config.jsonduring scaffolding.Why
Two issues we hit bootstrapping
ConductionNL/scholiqfrom/app-create:webpackaborted atnextcloud-vue/src/components/CnCard/CnCard.vue— Module parse failed for SCSS. The rule was there, the loader wasn't.info.xmlsummary still said "A template for creating new Nextcloud apps" — it survives the substitution phase because Phase 7 only rewrites identifier-shaped tokens (app-template→{APP_ID},AppTemplate→{APP_NAMESPACE}).Companion PR
ConductionNL/market-intelligenceupdates.claude/skills/app-create/references/placeholder-replacement-guide.mdso{APP_NAME},{APP_SUMMARY},{APP_DESCRIPTION}get auto-substituted fromopenspec/app-config.jsonduring scaffolding.Test plan