This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(scaffold): repair critical defaults — force:false, manifest alignment, nc-vue bump, repair-steps, seed RBAC#91
Merged
Conversation
…ment, nc-vue bump, repair-steps, seed RBAC - #74: Change repair step to loadConfiguration(force: false) — prevents operator-customised schemas being silently overwritten on every NC upgrade; keep force:true in SettingsController::load() for explicit resets only - #75: HealthController and MetricsController already exist (pre-solved) - #76: Align manifest schema/route on 'example'/'examples' to match seed register JSON slug and DeepLinkRegistrationListener (was: 'item'/'items'), fixing 404 on every fresh-install API call - #77: Bump @nextcloud/vue from ^8.16.0 to ^8.39.0 and add overrides entry to prevent NC34 nav-corner sliver regression in every scaffolded app - #79: Add InitializeSettings to info.xml <repair-steps> install + post- migration blocks so it fires after peer app autoloaders are fully loaded - #82: DeepLinkRegistrationListener already uses 'example'/'examples', consistent with manifest after #76 alignment (no code change needed) - #84: Add explicit rbac:true, multitenancy:true to register x-openregister and publicRead:false, publicWrite:false per schema so access control defaults are documented and stable across OR version bumps Closes #74, #75, #76, #77, #79, #82, #84
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
This was referenced May 27, 2026
Closed
Closed
rubenvdlinde
added a commit
that referenced
this pull request
May 27, 2026
…d AbstractToolHandler, initial-state, docusaurus bump - #78: Delete src/store/modules/object.js (bespoke Pinia store with no CSRF, no pagination, manual URL assembly). Replace with createObjectStore from @conduction/nextcloud-vue in store.js — fleet-standard store handling CSRF headers, pagination, and consistent error surfacing - #80: Remove '|| echo skip' from psalm/phpstan/phpmd scripts so composer check:strict correctly propagates non-zero exit codes when quality tools actually fail; tools are all in require-dev so they are always installed - #83: Refactor ExampleToolProvider to extend AbstractToolHandler so the fleet-standard requireWriteRole()/requireAdminUser() helpers are available; add AbstractToolHandler stub for standalone CI; update test constructor - #85: Replace data-version DOM attribute in admin.php with IInitialStateService::provideInitialState() (NC-standard CSP-compliant initial-state API); read via loadState('app-template','version') in Vue - #86: Bump @conduction/docusaurus-preset from ^3.4.0 to ^3.12.0 in docs/package.json — canonical fleet version auto-published from design-system Also fix registry.js status-badge appliesTo schema: 'item' → 'example' to align with the seed register slug corrected in PR #91. Closes #78, #80, #83, #85, #86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InitializeSettingsrepair step toloadConfiguration(force: false)— prevents operator-customised schemas from being silently overwritten on every Nextcloud upgrade.force: trueis kept only inSettingsController::load()(explicit operator-driven reset).HealthControllerandMetricsControlleralready exist in the codebase — issue is pre-solved by a prior commit.src/manifest.jsonschema/route onexample//examplesto match the seed register JSON slug andDeepLinkRegistrationListener. Wasitem//items, causing a 404 on every fresh-install API call.@nextcloud/vuefrom^8.16.0to^8.39.0and add anoverridesentry to prevent the NC34 nav-corner sliver regression in every app scaffolded from this template.InitializeSettingstoinfo.xml<repair-steps><install>and<post-migration>blocks so the step fires after all peer app autoloaders are fully loaded (vsregisterRepairStep()which fires during bootstrap).DeepLinkRegistrationListeneralready usesexample//examples/{uuid}— consistent with the manifest after the [CRITICAL] Manifest schema name 'item' mismatches seed register slug 'example' — fresh install 404s on every API call #76 alignment. No code change required; closing as part of this PR.rbac: true,multitenancy: trueto the registerx-openregisterblock andpublicRead: false,publicWrite: falseper schema so access control defaults are documented and stable across OpenRegister version bumps.Test plan
npm run check:specs— manifest, register, and registry validators pass/apps/app-template/api/objects?register=app-template&schema=examplereturns 200 (not 404)GET /api/healthandGET /api/metricsroutes work (controllers exist)@nextcloud/vueresolves to ^8.39.0 afternpm install