This repository was archived by the owner on May 29, 2026. It is now read-only.
fix(store+ci+mcp): delete bespoke object.js, fix composer gate, extend AbstractToolHandler, initial-state, docusaurus bump#92
Merged
Conversation
…d AbstractToolHandler, initial-state, docusaurus bump - #78: Delete src/store/modules/object.js (bespoke Pinia store with no CSRF, no pagination, manual URL assembly). Replace with createObjectStore from @conduction/nextcloud-vue in store.js — fleet-standard store handling CSRF headers, pagination, and consistent error surfacing - #80: Remove '|| echo skip' from psalm/phpstan/phpmd scripts so composer check:strict correctly propagates non-zero exit codes when quality tools actually fail; tools are all in require-dev so they are always installed - #83: Refactor ExampleToolProvider to extend AbstractToolHandler so the fleet-standard requireWriteRole()/requireAdminUser() helpers are available; add AbstractToolHandler stub for standalone CI; update test constructor - #85: Replace data-version DOM attribute in admin.php with IInitialStateService::provideInitialState() (NC-standard CSP-compliant initial-state API); read via loadState('app-template','version') in Vue - #86: Bump @conduction/docusaurus-preset from ^3.4.0 to ^3.12.0 in docs/package.json — canonical fleet version auto-published from design-system Also fix registry.js status-badge appliesTo schema: 'item' → 'example' to align with the seed register slug corrected in PR #91. Closes #78, #80, #83, #85, #86
This was referenced May 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/store/modules/object.js(bespoke Pinia store with ad-hoc URL assembly, no CSRF headers, no pagination). Replace withcreateObjectStorefrom@conduction/nextcloud-vueinstore.js— the fleet-standard store that handles CSRF, pagination, and consistent error surfacing. Also fixesregistry.jsstatus-badgeappliesTo.schema: 'item' → 'example'to align with the seed slug corrected in PR fix(scaffold): repair critical defaults — force:false, manifest alignment, nc-vue bump, repair-steps, seed RBAC #91.|| echo 'X not installed, skipping...'frompsalm,phpstan, andphpmdscripts incomposer.json. These tools are all inrequire-dev(always installed aftercomposer install), so the echo was silently swallowing real failures and lettingcheck:strictshow green with active errors.ExampleToolProviderto extendAbstractToolHandler(fleet-standard pattern, openbuilt PR #173). InheritsrequireWriteRole()andrequireAdminUser()helpers instead of an ad-hoc inline auth check. Addtests/Stubs/Mcp/AbstractToolHandler.phpfor standalone CI. UpdateExampleToolProviderTestto pass the newIGroupManagerconstructor parameter.data-versionDOM attribute intemplates/settings/admin.phpwithIInitialStateService::provideInitialState()— the NC-standard CSP-compliant initial-state API. Read in Vue vialoadState('app-template', 'version').@conduction/docusaurus-presetfrom^3.4.0to^3.12.0indocs/package.json— canonical fleet version auto-published from design-system main via semantic-release.Test plan
npm run check:specs— no regressionscomposer check:strict— psalm/phpstan/phpmd now propagate non-zero exit on failure./vendor/bin/phpunit --colors=always—ExampleToolProviderTestpasses with new IGroupManager mockdata-versionerrors in console)createObjectStoreimport resolves from@conduction/nextcloud-vueafternpm install