This repository was archived by the owner on May 29, 2026. It is now read-only.
chore(spec): merge advice-management [auto]#223
Merged
Conversation
Adds full OpenSpec artifact set for the Advice Management change: proposal, design (with Dutch seed data + reuse analysis), requirements spec (REQ-ADV-001/002/003 with GIVEN/WHEN/THEN scenarios), and implementation tasks with pre-commit verification checklist. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-18 16:33 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added a commit
that referenced
this pull request
May 10, 2026
Restores `npm ci`, `npm run lint`, and `npm run build` on `development`. Adds the missing peer-dependency chain for `@nextcloud/eslint-config@^8.4.1` and `@nextcloud/webpack-vue-config@^6.0.1`. `.npmrc` sets `legacy-peer-deps=true` so CI's `npm ci` (which doesn't take a flag) accepts the same resolution npm install produced. devDependencies added: - eslint-plugin-import ^2.32.0 - eslint-plugin-n ^16.6.2 - eslint-plugin-jsdoc ^46.10.1 - eslint-plugin-promise ^6.6.0 - eslint-plugin-vue ^9.33.0 - eslint-config-standard ^17.1.0 - @nextcloud/eslint-plugin ^2.2.1 - @vue/eslint-config-typescript ^13.0.0 - @babel/eslint-parser ^7.28.6 - @babel/core ^7.29.0 - eslint-import-resolver-exports ^1.0.0-beta.5 - eslint-import-resolver-typescript ^3.10.1 - node-polyfill-webpack-plugin ^3.0.0 - typescript ^5.9.3 dependencies added: - @nextcloud/auth ^2.6.0 (was used in 5 .vue files but never declared) Vue files in src/ contain only `npm run lint-fix` auto-fix output (vue/order-in-components reordering, attribute wrapping). No manual code edits. Mirror of pattern landed in decidesk #169, pipelinq #333, softwarecatalog #223. Gates after change: - `npm ci` succeeds - `npm run lint` — 7 errors / 13 warnings remain; these are pre-existing source bugs (parsing errors, v-slot scoping, unused vars, duplicate v-else-if) tracked separately in #323 — not caused by this baseline fix - `npm run build` — succeeds (webpack 5.105.2, 9 warnings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-created by Hydra supervisor. The Specter-generated spec for advice-management lives on
spec/advice-managementbut was never PR'd to development. The Builder needs it on development to pick up #123, so this PR merges the spec-only change. Review can be post-hoc — the spec contains no executable code, only design.md / proposal.md / tasks.md / specs/.