This repository was archived by the owner on May 29, 2026. It is now read-only.
chore: fix CI failures post-PR#2 (phpcs, eslint, docs, openspec-sync)#6
Merged
Merged
Conversation
- phpcs: move SPDX-License-Identifier inside file docblock for 4 lib files (AppInfo/Application, Controller/DashboardController, Sections/SettingsSection, Settings/AdminSettings) — the `// SPDX-...` line above the docblock triggered file-comment-style errors. - eslint: add `@nextcloud/auth` to dependencies (used by src/store/modules/object.js and settings.js for getRequestToken); fixes `n/no-extraneous-import` errors. - docs: change docusaurus `ci` script from `npm ci` to `npm install` since no docusaurus/package-lock.json is committed. - openspec-sync: pin reusable workflow to `@feature/openspec-project-sync` (matches other apps; `@main` does not yet contain this workflow).
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-11 11:11 UTC
Download the full PDF report from the workflow artifacts.
Previous commit regenerated the entire lockfile via `npm install`, which created an `npm ci`-incompatible result on the runner (ERESOLVE on @typescript-eslint/utils peer dep mismatch). This commit: - pins @nextcloud/auth to ^2.5.0 (matches existing transitive 2.5.3 in lockfile) - restores the original lockfile from b50e9a3 and adds only the top-level @nextcloud/auth declaration (1 line) Verified: `npm ci --legacy-peer-deps` succeeds locally.
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 215/215 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-11 11:19 UTC
Download the full PDF report from the workflow artifacts.
The unanchored 'js/' and 'css/' rules matched any nested directory, silently excluding docusaurus/src/css/custom.css from git. Result: the Deploy Documentation workflow failed at every build with 'Cannot find module ./src/css/custom.css' because the Docusaurus config referenced a file that was never committed. Fix: anchor to root via leading slash — '/js/', '/css/', '/dist/'. Matches the pattern used in decidesk and the upstream nextcloud-app-template. Also commit the previously-untracked docusaurus/src/ directory so the docs build can find its custom CSS.
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 215/215 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-11 11:23 UTC
Download the full PDF report from the workflow artifacts.
Docusaurus 3.8.1 is incompatible with the bundled webpack ProgressPlugin API (unknown properties 'name', 'color', 'reporters', 'reporter'). Pin to the 3.7.x range using a tilde to match the working version used by mydash/opencatalogi/etc. and avoid auto-upgrade.
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 215/215 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-11 11:26 UTC
Download the full PDF report from the workflow artifacts.
Docusaurus 3.7 + webpack 5 ProgressPlugin schema validation rejects
the legacy require('prism-react-renderer/themes/github') / dracula
loading pattern, failing the docs build with:
Progress Plugin has been initialized using an options object that
does not match the API schema.
openconnector's docusaurus config uses inline theme objects and
builds successfully. Adopting the same pattern: plain github-light +
dracula-dark inline. Themes are intentionally minimal — extend later
if syntax highlighting becomes a UX priority.
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 215/215 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-11 11:29 UTC
Download the full PDF report from the workflow artifacts.
…ema error Webpack 5.105+ removed the 'name'/'color'/'reporters'/'reporter' options from ProgressPlugin's schema. Docusaurus 3.7 still passes these options, causing a build-time ValidationError. Pin webpack to 5.99.9 via npm overrides (the last release before the schema change) to unblock the docs build.
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 215/215 | |||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/3 statements)
Quality workflow — 2026-05-11 11:33 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 4 CI checks that started failing after PR #2 merged on
development:SPDX-License-Identifierinto the file docblock (the// SPDX-...line above the docblock triggeredSquiz.Commenting.FileCommenterrors) for:lib/AppInfo/Application.php,lib/Controller/DashboardController.php,lib/Sections/SettingsSection.php,lib/Settings/AdminSettings.php.@nextcloud/authtodependencies(used bysrc/store/modules/object.jsandsettings.jsforgetRequestToken); resolvesn/no-extraneous-import.docusaurus/package.jsonciscript fromnpm citonpm installsince nodocusaurus/package-lock.jsonis committed.@feature/openspec-project-sync(matches opencatalogi, decidesk, mydash, etc.);@maindoes not yet containopenspec-sync.yml.Test plan
composer phpcs— passes locally (8/8 files, 0 errors)quality / PHP Quality (phpcs)greenquality / Vue Quality (eslint)greenDeploy DocumentationgreenOpenSpec Syncgreen