This repository was archived by the owner on May 29, 2026. It is now read-only.
fix: SCSS support + real Scholiq info.xml + drop broken symlink#2
Merged
rubenvdlinde merged 1 commit intoMay 11, 2026
Merged
Conversation
Backports the three template gaps that prevented v0.1 from building + the marketing-copy issue that left info.xml saying 'A template for creating new Nextcloud apps'. Changes: - webpack.config.js: add SCSS rule (style-loader + css-loader + sass-loader). Without this, '@conduction/nextcloud-vue' components shipping <style lang=scss> blocks (e.g. CnCard.vue) cause webpack to fail with 'Module parse failed: Unexpected token'. - package.json + package-lock.json: add sass ^1.99.0 and sass-loader ^16.0.8 to devDependencies. - appinfo/info.xml: replace template marketing copy with real Scholiq summary + description covering the v0.1 compliance-audit wedge, Phase 2-5 capabilities, technical foundations, and standards coverage. Both nl + en locales filled. - openspec/schemas/conduction: delete the broken symlink that pointed outside the app tree to '../../../.claude/openspec/schemas/conduction'. The symlink came from the template's main branch (already removed on development). It blocks docker cp + git-archive tarballs and doesn't resolve inside any container. Result: 'npm run build' completes with only entry-size warnings (no errors). Visiting /apps/scholiq in NC will no longer 500 once the rebuilt bundles are synced into the container. Companion PRs: - ConductionNL/nextcloud-app-template#28 — adds sass + sass-loader to template devDependencies, replaces info.xml marketing copy with {APP_NAME} + {APP_SUMMARY} + {APP_DESCRIPTION} placeholders. - ConductionNL/market-intelligence — updates .claude/skills/app-create/references/placeholder-replacement-guide.md to substitute the new placeholders from openspec/app-config.json.
Contributor
Quality Report — ConductionNL/scholiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 215/215 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-11 10:09 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three local fixes so v0.1 builds and the app reads as Scholiq instead of "Nextcloud App Template":
{ test: /\.scss$/, use: ['style-loader', 'css-loader', 'sass-loader'] }. Without it,@conduction/nextcloud-vuecomponents shipping<style lang="scss">(e.g.CnCard.vue) make webpack fail withModule parse failed: Unexpected token.sass ^1.99.0+sass-loader ^16.0.8to devDeps.A template for creating new Nextcloud apps) with real Scholiq summary + description covering the v0.1 compliance-audit wedge, Phase 2-5 capabilities, technical foundations, and standards coverage. Both nl + en filled.../../../.claude/openspec/schemas/conduction. Came from the template'smainbranch (already removed ondevelopment); blocksdocker cpandgit archive.Why
Two issues hit during
/app-create scholiqbootstrapping:/apps/scholiq— webpack aborted on the SCSS file, sojs/scholiq-*.jsbundles didn't exist.info.xmlsummary still said "A template for creating new Nextcloud apps" — placeholder substitution only handled identifier tokens.After this PR:
npm run buildcompletes with only entrypoint-size warnings (no errors), and<summary>/<description>show real Scholiq copy.Companion PRs
ConductionNL/market-intelligence(next) — updates the/app-createskill's placeholder-replacement guide.Test plan
npm run build→ 0 errors (entrypoint-size warnings expected, not blocking)docker cpworks (no symlink dereference error)/apps/scholiqreturns 200 (or 302 to login)