ProofAggregationCoordinatorService: Add poller for proof response#2601
Open
gauravahuja wants to merge 1 commit intomainfrom
Open
ProofAggregationCoordinatorService: Add poller for proof response#2601gauravahuja wants to merge 1 commit intomainfrom
gauravahuja wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2601 +/- ##
============================================
- Coverage 59.12% 58.85% -0.28%
- Complexity 1618 1624 +6
============================================
Files 454 457 +3
Lines 18471 18579 +108
Branches 2013 2016 +3
============================================
+ Hits 10921 10934 +13
- Misses 6883 6979 +96
+ Partials 667 666 -1
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
.../consensys/zkevm/ethereum/coordination/aggregation/ProofAggregationCoordinatorServiceTest.kt
Show resolved
Hide resolved
4 tasks
jonesho
reviewed
Mar 18, 2026
.../main/kotlin/net/consensys/zkevm/ethereum/coordination/aggregation/AggregationProofPoller.kt
Show resolved
Hide resolved
1a647a1 to
aee2178
Compare
6c9d62a to
992da02
Compare
.../main/kotlin/net/consensys/zkevm/ethereum/coordination/aggregation/AggregationProofPoller.kt
Show resolved
Hide resolved
aee2178 to
bf1e1a7
Compare
992da02 to
d600a71
Compare
.../main/kotlin/net/consensys/zkevm/ethereum/coordination/aggregation/AggregationProofPoller.kt
Show resolved
Hide resolved
Base automatically changed from
refactor_ProofAggregationCoordinatorService
to
main
March 20, 2026 06:23
d600a71 to
cf5506d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
.../main/kotlin/net/consensys/zkevm/ethereum/coordination/aggregation/AggregationProofPoller.kt
Show resolved
Hide resolved
.../net/consensys/zkevm/ethereum/coordination/aggregation/ProofAggregationCoordinatorService.kt
Show resolved
Hide resolved
jonesho
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part 2 of #2241
This PR implements issue(s) #2241
Checklist
PR.
Note
Medium Risk
Changes the aggregation proof flow from synchronous proof retrieval to an asynchronous request+polling model, which can affect aggregation finalization timing and error/retry behavior. New background polling introduces potential ordering/backlog issues if not carefully monitored.
Overview
Decouples aggregation proof generation into two steps:
ProofAggregationCoordinatorServicenow submits a proof request viacreateProofRequest(getting anAggregationProofIndex) and defers completion until a newAggregationProofPollerretrieves the proof viafindProofResponseand then callsaggregationProofHandler.Wires the poller into the service lifecycle (
start/stop), removes unused L2 client parameters fromProofAggregationCoordinatorService.create, and updates the coordinator test to mock the new request/index + polling behavior.Written by Cursor Bugbot for commit cf5506d. This will update automatically on new commits. Configure here.