Skip to content

ProofAggregationCoordinatorService: Add poller for proof response#2601

Open
gauravahuja wants to merge 1 commit intomainfrom
refactor_ProofAggregationCoordinatorService_2
Open

ProofAggregationCoordinatorService: Add poller for proof response#2601
gauravahuja wants to merge 1 commit intomainfrom
refactor_ProofAggregationCoordinatorService_2

Conversation

@gauravahuja
Copy link
Contributor

@gauravahuja gauravahuja commented Mar 17, 2026

Part 2 of #2241
This PR implements issue(s) #2241

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • If this change is deployed to any environment (including Devnet), E2E test coverage exists or is included in this
    PR.
  • I have informed the team of any breaking changes if there are any.

Note

Medium Risk
Changes the aggregation proof flow from synchronous proof retrieval to an asynchronous request+polling model, which can affect aggregation finalization timing and error/retry behavior. New background polling introduces potential ordering/backlog issues if not carefully monitored.

Overview
Decouples aggregation proof generation into two steps: ProofAggregationCoordinatorService now submits a proof request via createProofRequest (getting an AggregationProofIndex) and defers completion until a new AggregationProofPoller retrieves the proof via findProofResponse and then calls aggregationProofHandler.

Wires the poller into the service lifecycle (start/stop), removes unused L2 client parameters from ProofAggregationCoordinatorService.create, and updates the coordinator test to mock the new request/index + polling behavior.

Written by Cursor Bugbot for commit cf5506d. This will update automatically on new commits. Configure here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 87.75510% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.85%. Comparing base (02862e9) to head (cf5506d).

Files with missing lines Patch % Lines
.../aggregation/ProofAggregationCoordinatorService.kt 68.75% 5 Missing ⚠️
...coordination/aggregation/AggregationProofPoller.kt 96.96% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2601      +/-   ##
============================================
- Coverage     59.12%   58.85%   -0.28%     
- Complexity     1618     1624       +6     
============================================
  Files           454      457       +3     
  Lines         18471    18579     +108     
  Branches       2013     2016       +3     
============================================
+ Hits          10921    10934      +13     
- Misses         6883     6979      +96     
+ Partials        667      666       -1     
Flag Coverage Δ *Carryforward flag
hardhat 96.53% <ø> (ø) Carriedforward from 02862e9
kotlin 54.69% <87.75%> (-0.28%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../zkevm/coordinator/app/conflation/ConflationApp.kt 0.00% <ø> (ø)
...coordination/aggregation/AggregationProofPoller.kt 96.96% <96.96%> (ø)
.../aggregation/ProofAggregationCoordinatorService.kt 64.02% <68.75%> (-1.13%) ⬇️

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauravahuja gauravahuja requested a review from a team March 17, 2026 10:03
@gauravahuja gauravahuja force-pushed the refactor_ProofAggregationCoordinatorService branch from 1a647a1 to aee2178 Compare March 19, 2026 04:25
@gauravahuja gauravahuja force-pushed the refactor_ProofAggregationCoordinatorService_2 branch 2 times, most recently from 6c9d62a to 992da02 Compare March 19, 2026 04:29
@gauravahuja gauravahuja force-pushed the refactor_ProofAggregationCoordinatorService branch from aee2178 to bf1e1a7 Compare March 19, 2026 05:13
@gauravahuja gauravahuja force-pushed the refactor_ProofAggregationCoordinatorService_2 branch from 992da02 to d600a71 Compare March 19, 2026 05:22
Base automatically changed from refactor_ProofAggregationCoordinatorService to main March 20, 2026 06:23
@gauravahuja gauravahuja force-pushed the refactor_ProofAggregationCoordinatorService_2 branch from d600a71 to cf5506d Compare March 20, 2026 06:29
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

There are 3 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants