fix(review): root nested pnpm lock hashes - #645
Merged
Conversation
📝 WalkthroughWalkthrough커버리지 증거 생성 시 pnpm lockfile 해시 경로를 검증된 worktree 내부로 고정하고, CI 및 계약 테스트의 관련 단정을 새 호출 방식에 맞게 갱신했습니다. ChangesCoverage lockfile verification
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
원인
중앙 OpenCode 실행 30439758983은
ContextualWisdomLab/naruon#1179@93e56e6의frontend/pnpm-lock.yaml을 검증한 뒤 이미/work/frontend로 이동한 상태에서 다시 저장소 상대 경로frontend/pnpm-lock.yaml을 해시했습니다. 그 결과frontend/frontend/pnpm-lock.yaml을 열려다 coverage evidence가 실패했습니다.변경
COVERAGE_SOURCE_WORKDIR에 고정합니다.--ignore-scripts및 PR 제어 경로 격리는 그대로 유지합니다.검증
python3 -m pytest -q tests/test_opencode_agent_contract.py— 37 passedpython3 -m pytest -q— 674 passedruff check .— passedscripts/ci/test_strix_quick_gate.sh— PASS (242 scenarios)actionlint -shellcheck= .github/workflows/opencode-review-dispatch.yml— passedbash -n scripts/ci/test_strix_quick_gate.sh— passedgit diff --check— passedeffc1257f1841189db186b291234c2a678dd5c85로 일치함을 중첩frontendcwd에서 재현Unblocks ContextualWisdomLab/naruon#1179