Skip to content

fix(review): root nested pnpm lock hashes - #645

Merged
seonghobae merged 1 commit into
mainfrom
codex/fix-nested-pnpm-lock-path
Jul 29, 2026
Merged

fix(review): root nested pnpm lock hashes#645
seonghobae merged 1 commit into
mainfrom
codex/fix-nested-pnpm-lock-path

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

원인

중앙 OpenCode 실행 30439758983ContextualWisdomLab/naruon#1179@93e56e6frontend/pnpm-lock.yaml을 검증한 뒤 이미 /work/frontend로 이동한 상태에서 다시 저장소 상대 경로 frontend/pnpm-lock.yaml을 해시했습니다. 그 결과 frontend/frontend/pnpm-lock.yaml을 열려다 coverage evidence가 실패했습니다.

변경

  • worktree lock hash를 현재 패키지 작업 디렉터리가 아니라 검증된 COVERAGE_SOURCE_WORKDIR에 고정합니다.
  • 중첩 pnpm 프로젝트가 저장소 상대 lock 경로를 이중 접두사로 해시하지 않는 정적 계약을 Bash/Python 회귀 테스트에 추가합니다.
  • base/head blob 검증, exact lock equality, offline store, --ignore-scripts 및 PR 제어 경로 격리는 그대로 유지합니다.

검증

  • python3 -m pytest -q tests/test_opencode_agent_contract.py — 37 passed
  • python3 -m pytest -q — 674 passed
  • ruff check . — passed
  • scripts/ci/test_strix_quick_gate.sh — PASS (242 scenarios)
  • actionlint -shellcheck= .github/workflows/opencode-review-dispatch.yml — passed
  • bash -n scripts/ci/test_strix_quick_gate.sh — passed
  • YAML parse 및 git diff --check — passed
  • Naruon exact base/head/worktree lock blob가 모두 effc1257f1841189db186b291234c2a678dd5c85로 일치함을 중첩 frontend cwd에서 재현

Unblocks ContextualWisdomLab/naruon#1179

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

커버리지 증거 생성 시 pnpm lockfile 해시 경로를 검증된 worktree 내부로 고정하고, CI 및 계약 테스트의 관련 단정을 새 호출 방식에 맞게 갱신했습니다.

Changes

Coverage lockfile verification

Layer / File(s) Summary
Worktree lockfile hashing and validation
.github/workflows/opencode-review-dispatch.yml, scripts/ci/test_strix_quick_gate.sh, tests/test_opencode_agent_contract.py
trusted_git hash-objectCOVERAGE_SOURCE_WORKDIR 기준 lockfile을 해시하도록 변경되었으며, CI와 계약 테스트가 기존 상대 경로 호출을 금지하고 새 경로를 검증합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목이 nested pnpm lock 해시 수정이라는 핵심 변경을 짧고 명확하게 요약합니다.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-nested-pnpm-lock-path

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 66c2b1d into main Jul 29, 2026
45 checks passed
@seonghobae
seonghobae deleted the codex/fix-nested-pnpm-lock-path branch July 29, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant