Skip to content

fix(review): root nested pnpm lock hashes #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Jul 29, 2026
Merged

fix(review): root nested pnpm lock hashes #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/opencode-review-dispatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,10 @@ jobs:
echo "::error::Validated head does not contain ${relative_lock}."
return 1
}
worktree_blob="$(trusted_git hash-object --no-filters -- "$relative_lock")" || {
worktree_blob="$(
trusted_git hash-object --no-filters -- \
"$COVERAGE_SOURCE_WORKDIR/$relative_lock"
)" || {
echo "::error::Could not hash current pnpm lock ${relative_lock}."
return 1
}
Expand Down
3 changes: 2 additions & 1 deletion scripts/ci/test_strix_quick_gate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,8 @@ assert_opencode_review_uses_codegraph_and_gpt5_fallback() {
assert_file_contains "$workflow_file" "--offline" "coverage dependency installation refuses pnpm registry access"
assert_file_contains "$workflow_file" "--ignore-scripts" "coverage dependency installation suppresses pnpm lifecycle hooks"
assert_file_contains "$workflow_file" "trusted_pnpm_lock_matches_base()" "coverage validates the exact base and current lock before trusting it"
assert_file_contains "$workflow_file" 'trusted_git hash-object --no-filters -- "$relative_lock"' "coverage verifies the sandbox lock still matches the validated commit"
assert_file_contains "$workflow_file" '"$COVERAGE_SOURCE_WORKDIR/$relative_lock"' "coverage hashes nested pnpm locks from the validated worktree root"
assert_file_not_contains "$workflow_file" 'hash-object --no-filters -- "$relative_lock"' "coverage does not double-prefix nested package lock paths from the package working directory"
assert_file_contains "$workflow_file" "--trust-lockfile" "coverage suppresses registry attestation lookups only for an exact trusted-base lock"
assert_file_contains "$workflow_file" "prepare_writable_pnpm_store()" "coverage prepares a sandbox-writable clone of the trusted pnpm store"
assert_file_contains "$workflow_file" 'destination="$(mktemp -d /tmp/opencode-pnpm-store.XXXXXX)"' "coverage creates the writable pnpm store at an unpredictable root-owned path"
Expand Down
4 changes: 3 additions & 1 deletion tests/test_opencode_agent_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,9 +380,11 @@ def test_opencode_target_coverage_materializes_only_after_authorized_dispatch():
in measure_step
)
assert (
'worktree_blob="$(trusted_git hash-object --no-filters -- "$relative_lock")"'
'trusted_git hash-object --no-filters -- \\\n'
' "$COVERAGE_SOURCE_WORKDIR/$relative_lock"'
in measure_step
)
assert 'hash-object --no-filters -- "$relative_lock"' not in measure_step
assert "refusing --trust-lockfile for PR-controlled dependency resolution" in measure_step
assert "prepare_writable_pnpm_store()" in measure_step
assert (
Expand Down
Loading