Skip to content

feat(temporal): add typed six-clock values and uncertain intervals - #5

Draft
seonghobae wants to merge 55 commits into
mainfrom
agent/task-3-six-clock-intervals
Draft

feat(temporal): add typed six-clock values and uncertain intervals#5
seonghobae wants to merge 55 commits into
mainfrom
agent/task-3-six-clock-intervals

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Scope

This Task 3 change adds TEPP's typed temporal foundation:

  • distinct EventTime, AssertionTime, DocumentTime, SystemTime, AvailableTime, and KnowledgeCutoff nominal types;
  • strict RFC 3339 parsing with explicit seconds and offsets, nanosecond precision, deterministic UTC normalization, and rejection of ambiguous or lossy forms;
  • exact, bounded, open-ended, and explicitly unknown typed intervals;
  • included, excluded, and unbounded boundaries;
  • source precision from nanosecond through year plus unknown;
  • fail-closed reversed, empty, semantically inconsistent, and unknown-precision intervals;
  • strict versioned JSON clock and interval records with unknown-field, version, clock-type, malformed-boundary, and timestamp rejection;
  • Draft 2020-12 JSON Schema output; and
  • stable content-redacting temporal errors.

The implementation is Rust-only production logic and preserves nominal clock distinctions across parsing, ordering, interval validation, serialization, reconstruction, and schema generation.

Verification contract

This PR remains Draft until the current exact head satisfies:

  • cargo fmt --check;
  • warning-free workspace build, Clippy, tests, and rustdoc;
  • production line coverage 100%;
  • production branch coverage 100%;
  • public rustdoc and repository contract checks;
  • dependency, supply-chain, SAST, and security checks; and
  • review of the exact head.

Claim boundary

This PR does not claim temporal reasoner closure, event ontology, database persistence, GPU kernels, topic estimation, ESEM/DSEM modeling, deployment, release, or commercial KPI evidence.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f803adb-aea0-460f-9ec5-dab19b4c113d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae changed the base branch from agent/task-2-immutable-evidence to main August 6, 2026 02:33

Copy link
Copy Markdown
Contributor Author

@opencode-agent address

Keep this PR Draft and repair exact current head 5da25b764dfceccdab63f4cb0488913fc04b24c5 without weakening the quality gates. Run cargo fmt --all, inspect the permanent line and branch coverage reports, and add behavior tests for every uncovered temporal path until production line coverage is 100% and branch coverage is 100%. In particular exercise exact/bounded/unknown interval semantics, lower/upper included/excluded/unbounded combinations and contains short-circuits, invalid known/unknown precision, all-unbounded rejection, equal and unequal exact boundaries, malformed or mismatched clock/interval wire records, and strict RFC 3339 separator, digit, fraction, offset, leap-second, and terminal-shape failures. Do not add #[coverage(off)], ignore regions, generated-code exclusions, lowered thresholds, wrapper-only assertions, or transient repair files. Preserve the six nominal clocks, immutable evidence types, stable redacted errors, JSON Schema Draft 2020-12 contracts, Rust 1.97.1 baseline, full public rustdoc, CHANGELOG, and APA 7 doctoring. After the same head passes formatting, clippy, tests, rustdoc, deny, schema checks, 100% line/branch coverage, Security Scan, and Semgrep, update the PR description with only exact-current-head evidence and request independent review.

Copy link
Copy Markdown
Contributor Author

@opencode-agent address

Exact head 175f1bde3c6d2b46f2ec19a9a5bc4d9317ea993c is now green for formatting, compile, Clippy, tests, rustdoc, dependency policy, repository contracts, and 100% branch coverage; line coverage is the sole remaining failure at 1037/1038, attributed to one generic region in crates/temporal_core/src/wire.rs. Add a permanent all-six-clock wire contract—clock JSON round-trip, exact/bounded/open/unknown interval JSON round-trip, and clock-specific Draft 2020-12 schema assertions for EventTime, AssertionTime, DocumentTime, SystemTime, AvailableTime, and KnowledgeCutoff—so every generic wire instantiation is executed. Do not add exclusions or alter production semantics. Remove .github/workflows/repair-pr5-temporal-coverage.yml, rerun exact-head line and branch coverage, and keep Draft until both are 100% and every current-head security/review gate is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant